Page MenuHomePhabricator

[analyzer] Move test case to existing test file and remove duplicated test file.
ClosedPublic

Authored by ASDenysPetrov on Jul 16 2021, 7:20 AM.

Details

Summary

Move the test case to existing test file. Remove test file as duplicated. The file was mistakenly added due to concerns of a hidden bug (see D104381). After it turned out, that the bug was already fixed with another revision (D85817) and corresponding test was added as well, we can remove this file.

Diff Detail

Event Timeline

ASDenysPetrov created this revision.Jul 16 2021, 7:20 AM
ASDenysPetrov requested review of this revision.Jul 16 2021, 7:20 AM
NoQ accepted this revision.Jul 16 2021, 7:55 PM

I have no opinion here. There's nothing wrong with having more tests and they don't look like exact duplicates of each other(?)

This revision is now accepted and ready to land.Jul 16 2021, 7:55 PM
ASDenysPetrov added a comment.EditedJul 19 2021, 2:22 AM

I have no opinion here. There's nothing wrong with having more tests and they don't look like exact duplicates of each other(?)

OK, let's just make a compromise and move this test into existing one instead of removing. WDYT?

ASDenysPetrov retitled this revision from [analyzer] Remove test file as duplicated. to [analyzer] Move test case to existing test file and remove duplicated test file..
ASDenysPetrov edited the summary of this revision. (Show Details)

Moved the test case to existing file.

I think the patch is pretty safe, then I decided to load it.