This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.
ClosedPublic

Authored by anjankgk on Jul 15 2021, 8:55 AM.

Details

Summary

Emit the unsupported option error until the Clang's library integration support for 128-bit long double is available for AIX.

Diff Detail

Event Timeline

anjankgk requested review of this revision.Jul 15 2021, 8:55 AM
anjankgk created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2021, 8:55 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Whitney accepted this revision.Jul 16 2021, 11:32 AM
This revision is now accepted and ready to land.Jul 16 2021, 11:32 AM

Thanks for reviewing! Can someone with commit access help commit this pls?
Thanks in advance!

cebowleratibm requested changes to this revision.Jul 19 2021, 8:24 AM
cebowleratibm added a subscriber: cebowleratibm.
cebowleratibm added inline comments.
clang/lib/Driver/ToolChains/Clang.cpp
4845

It's not that AIX doesn't support 128-bit long double. The xlc compiler has -qldbl128, which links in different libraries for 128-bit. The XL compilers use -lc128 and -lC128 so there are binary compatibility concerns that need to be investigated.

I suggest this comment be updated accordingly.

This revision now requires changes to proceed.Jul 19 2021, 8:24 AM
hubert.reinterpretcast edited the summary of this revision. (Show Details)Jul 19 2021, 9:06 AM
hubert.reinterpretcast added inline comments.
clang/lib/Driver/ToolChains/Clang.cpp
4845

Note also to update the commit message.

anjankgk updated this revision to Diff 359926.Jul 19 2021, 2:43 PM
anjankgk retitled this revision from [AIX] Emit unsupported 128-bit long double option for AIX to [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX..
anjankgk edited the summary of this revision. (Show Details)

Updated the comment

This revision is now accepted and ready to land.Jul 20 2021, 11:52 AM

@cebowleratibm @Whitney Could either of you pls commit this?
Thanks!

xgupta added a subscriber: xgupta.Jul 21 2021, 7:42 AM

@anjankgk You need to provide your identity for commit in "your name <your email>" form.
see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Prior to obtaining commit access, it is common practice to request that someone with commit access commits on your behalf. When doing so, please provide the name and email address you would like to use in the Author property of the commit.

@anjankgk You need to provide your identity for commit in "your name <your email>" form.
see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Prior to obtaining commit access, it is common practice to request that someone with commit access commits on your behalf. When doing so, please provide the name and email address you would like to use in the Author property of the commit.

Here's the info:
Anjan Kumar Guttahalli Krishna <anjankumar.g.k@ca.ibm.com>

Thank you!

Since Whitny and Chris are busy, I have requested Shimin to commit this in.
Thanks Shimin!

This revision was landed with ongoing or failed builds.Jul 22 2021, 12:35 PM
This revision was automatically updated to reflect the committed changes.