This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Enable dollar sign as PC in inlineasm
ClosedPublic

Authored by jsji on Jul 13 2021, 6:40 PM.

Details

Reviewers
shchenz
amyk
nemanjai
Group Reviewers
Restricted Project
Commits
rGfe52296a3433: [AIX] Enable dollar sign as PC in inlineasm
Summary

$ is used as PC for PowerPC inlineasm, ELF use it,
enable it for AIX XCOFF as well.

Diff Detail

Event Timeline

jsji created this revision.Jul 13 2021, 6:40 PM
jsji requested review of this revision.Jul 13 2021, 6:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2021, 6:40 PM

Is it possible to also add an MC test case for this (similar to test/MC/PowerPC/ppc64-operands.s)?

llvm/test/CodeGen/PowerPC/inline-asm-dollarpc.ll
4

Minor nit: IS isn't clear as a prefix, how about IAS for Integrated AS?

jsji updated this revision to Diff 358499.Jul 13 2021, 8:04 PM

Address comments.

nemanjai accepted this revision.Jul 14 2021, 4:08 AM

LGTM.

This revision is now accepted and ready to land.Jul 14 2021, 4:08 AM
amyk accepted this revision.Jul 14 2021, 6:21 AM

Also LGTM. Thanks Jinsong.

This revision was landed with ongoing or failed builds.Jul 14 2021, 6:54 AM
This revision was automatically updated to reflect the committed changes.