[NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

[alexfh]

LG. I can commit the patch for you.

[thakis]

I think this is incorrect. See D105892 and https://reviews.llvm.org/D104915#2873851 . Don't blindly land changes to suppress warnings – the warnings exist to tell us something :)

[alexfh]

In D105890#2873969, @thakis wrote:

I think this is incorrect. See D105892 and https://reviews.llvm.org/D104915#2873851 . Don't blindly land changes to suppress warnings – the warnings exist to tell us something :)

Indeed, thanks for pointing this out! On the other hand, it may be worth adding this warning with -Werror to the default set or at least enable it when running pre-merge checks.

clang/lib/Sema/SemaDeclAttr.cpp

static void handleOpenCLAccessAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
   // cannot read from and write to the same pipe object. Using the read_write
   // (or __read_write) qualifier with the pipe qualifier is a compilation error.
   // OpenCL v3.0 s6.8 - For OpenCL C 2.0, or with the
   // __opencl_c_read_write_images feature, image objects specified as arguments
   // to a kernel can additionally be declared to be read-write.
   if (const auto *PDecl = dyn_cast<ParmVarDecl>(D)) {
     const Type *DeclTy = PDecl->getType().getCanonicalType().getTypePtr();
     if (AL.getAttrName()->getName().find("read_write") != StringRef::npos) {
-      if ((!S.getLangOpts().OpenCLCPlusPlus &&
-               (S.getLangOpts().OpenCLVersion < 200) ||
+      if (((!S.getLangOpts().OpenCLCPlusPlus &&
+            (S.getLangOpts().OpenCLVersion < 200)) ||
            (S.getLangOpts().OpenCLVersion == 300 &&
             !S.getOpenCLOptions().isSupported("__opencl_c_read_write_images",
                                               S.getLangOpts()))) ||
           DeclTy->isPipeType()) {
         S.Diag(AL.getLoc(), diag::err_opencl_invalid_read_write)
             << AL << PDecl->getType() << DeclTy->isImageType();
         D->setInvalidDecl(true);
         return;