Page MenuHomePhabricator

[MLIR][StandardToLLVM] Move `copyUnrankedDescriptors` to pattern
ClosedPublic

Authored by frgossen on Jul 12 2021, 5:14 AM.

Details

Summary

Make the function copyUnrankedDescriptors accessible in
ConvertToLLVMPattern.

Diff Detail

Event Timeline

frgossen created this revision.Jul 12 2021, 5:14 AM
frgossen requested review of this revision.Jul 12 2021, 5:14 AM
ftynse accepted this revision.Jul 12 2021, 5:22 AM
ftynse added inline comments.
mlir/include/mlir/Conversion/LLVMCommon/Pattern.h
122

How does it know where the memory was?

This revision is now accepted and ready to land.Jul 12 2021, 5:22 AM
frgossen updated this revision to Diff 357917.Jul 12 2021, 6:14 AM
frgossen marked an inline comment as done.

Address comment

Thanks!

mlir/include/mlir/Conversion/LLVMCommon/Pattern.h
122

It decides that based on toDynamic. Clarified this in the comment.

This revision was landed with ongoing or failed builds.Jul 12 2021, 6:35 AM
This revision was automatically updated to reflect the committed changes.