Added shape inference handles cases for convolution operations. This includes
conv2d, conv3d, depthwise_conv2d, and transpose_conv2d. With transpose conv
we use the specified output shape when possible however will shape propagate
if the output shape attribute has dynamic values.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Quick comment (forgot to hit send earlier, will do full review tomorrow)
mlir/lib/Dialect/Tosa/IR/TosaOps.cpp | ||
---|---|---|
440 | outputShape(4, ShapedType::kDynamic) ? (then you can avoid resize below) | |
444 | Could we use ShapedType::kDynamic here and below or does -1 not signal dynamic but something else? | |
466 | If we can use kDynamic above, then this becomes ShapedType::isDynamic(outputShape[3]) |
outputShape(4, ShapedType::kDynamic) ? (then you can avoid resize below)