Page MenuHomePhabricator
Differential D105427

[mlir][linalg] Tighter StructuredOp Verification.
ClosedPublic
Actions

Authored by gysit on Jul 5 2021, 5:04 AM.

Details

Reviewers
nicolasvasilache
Commits
rG511af1b1ad00: [mlir][linalg] Tighter StructuredOp Verification.
Summary

Verify the number of results matches exactly the number of output tensors. Simplify the FillOp verification since part of it got redundant.

Diff Detail

Event Timeline

gysit created this revision.Jul 5 2021, 5:04 AM
Herald added subscribers: dcaballe, cota, mravishankar and 17 others. · View Herald TranscriptJul 5 2021, 5:04 AM
gysit requested review of this revision.Jul 5 2021, 5:04 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJul 5 2021, 5:04 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
gysit updated this revision to Diff 356485.Jul 5 2021, 5:17 AM

Remove additional TODO.

Harbormaster completed remote builds in B112433: Diff 356485.Jul 5 2021, 5:53 AM
nicolasvasilache accepted this revision.Jul 7 2021, 1:34 PM
This revision is now accepted and ready to land.Jul 7 2021, 1:34 PM
gysit updated this revision to Diff 357138.Jul 7 2021, 11:23 PM

Rebase.

This revision was landed with ongoing or failed builds.Jul 7 2021, 11:54 PM
Closed by commit rG511af1b1ad00: [mlir][linalg] Tighter StructuredOp Verification. (authored by gysit). · Explain Why
This revision was automatically updated to reflect the committed changes.
gysit added a commit: rG511af1b1ad00: [mlir][linalg] Tighter StructuredOp Verification..
Harbormaster completed remote builds in B112920: Diff 357138.Jul 8 2021, 12:00 AM

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
Linalg/
IR/
10 lines
4 lines
test/
Dialect/
Linalg/
6 lines

Diff 356479

View Options

mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp

Loading...
View Options

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Loading...
View Options

mlir/test/Dialect/Linalg/invalid.mlir

Loading...