This is an archive of the discontinued LLVM Phabricator instance.

[ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references
ClosedPublic

Authored by epastor on Jul 2 2021, 1:18 PM.

Details

Summary

ML64.EXE applies implicit RIP-relative addressing only to memory references that include a named-variable reference.

Diff Detail

Event Timeline

epastor created this revision.Jul 2 2021, 1:18 PM
epastor requested review of this revision.Jul 2 2021, 1:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2021, 1:18 PM
mstorsjo accepted this revision.Jul 2 2021, 1:47 PM

LGTM, the test output seems reasonable to me.

With this, plus D104964 and D104965 I'm able to build the OpenMP assembly file for both i386 and x86_64. (I don't really have a big functional test setup for it though, but it compiles at least, so how wrong could it be?) ;-)

This revision is now accepted and ready to land.Jul 2 2021, 1:47 PM
epastor updated this revision to Diff 356379.Jul 4 2021, 7:17 AM

Restrict further to only named-variable references

epastor retitled this revision from [ms] [llvm-ml] Restrict implicit RIP-relative addressing to symbol references to [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.Jul 4 2021, 7:29 AM
epastor edited the summary of this revision. (Show Details)
epastor updated this revision to Diff 358037.Jul 12 2021, 12:43 PM

Rebase on parent

This revision was landed with ongoing or failed builds.Jul 21 2021, 8:50 AM
This revision was automatically updated to reflect the committed changes.