Page MenuHomePhabricator

[CFE][X86] Enable complex _Float16 support
ClosedPublic

Authored by pengfei on Jul 1 2021, 7:41 PM.

Details

Summary

Support complex _Float16 on X86 in C/C++ following the latest X86 psABI. (https://gitlab.com/x86-psABIs)

Diff Detail

Event Timeline

pengfei requested review of this revision.Jul 1 2021, 7:41 PM
pengfei created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2021, 7:41 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

The patch on itself looks reasonable to me. I was just wondering about the _Float16 support on X86 in general because the Clang docs says:

_Float16 is currently only supported on the following targets, with further targets pending ABI standardization: <list of non-X86 targets>

Does X86 support _Float16, and how does that work for Complex _Float16?
Either way, does this need a doc update too?

The patch on itself looks reasonable to me. I was just wondering about the _Float16 support on X86 in general because the Clang docs says:

_Float16 is currently only supported on the following targets, with further targets pending ABI standardization: <list of non-X86 targets>

Does X86 support _Float16, and how does that work for Complex _Float16?
Either way, does this need a doc update too?

Good point! Yes, X86 is going to support _Float16. This patch is split from D105263 and depended on it. I will update the doc in that patch. Thanks.

Would you check the failure of the test cases?

Would you check the failure of the test cases?

They failed due to they are built based on the ToT instead of the 1st patch of FP16.

Could you add the linkage of ABI in the commit message?

pengfei retitled this revision from [CFE][X86] Enable complex _Float16. to [CFE][X86] Enable complex _Float16 support.Aug 16 2021, 1:40 AM
pengfei edited the summary of this revision. (Show Details)
LuoYuanke accepted this revision.Aug 16 2021, 1:58 AM

LGTM, but wait 1 or 2 days to see if there is any comments from others.

This revision is now accepted and ready to land.Aug 16 2021, 1:58 AM
This revision was automatically updated to reflect the committed changes.