This is an archive of the discontinued LLVM Phabricator instance.

Differential D105292

[NFC] Mark Expected<T>::assertIsChecked() as const
ClosedPublic

Authored by xndcn on Jul 1 2021, 9:03 AM.

Details

Reviewers
chandlerc
sammccall
Commits
rG7445f1e4dcd4: [NFC] Mark Expected<T>::assertIsChecked() as const
Summary

Some const methods of Expected<T> invoke assertIsChecked(), so we should mark it as const too.

Diff Detail

Event Timeline

xndcn created this revision.Jul 1 2021, 9:03 AM
Herald added a subscriber: dexonsmith. · View Herald TranscriptJul 1 2021, 9:03 AM
xndcn requested review of this revision.Jul 1 2021, 9:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2021, 9:03 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
xndcn updated this revision to Diff 355933.Jul 1 2021, 10:27 AM
Harbormaster completed remote builds in B112026: Diff 355933.Jul 1 2021, 11:47 AM
xndcn edited reviewers, added: sammccall; removed: labath.Jul 6 2021, 8:26 AM
xndcn removed a reviewer: lhames.
sammccall accepted this revision.Jul 6 2021, 11:34 PM

LG thanks!
I guess this didn't cause problems so far because usage of const Expected is rare.

(next time please upload with full context)

llvm/unittests/Support/ErrorTest.cpp
574

Nit: unchecked (typo)

This revision is now accepted and ready to land.Jul 6 2021, 11:34 PM
xndcn updated this revision to Diff 356973.Jul 7 2021, 8:21 AM

@sammccall Thanks! Fixed 3 typo.

Harbormaster completed remote builds in B112795: Diff 356973.Jul 7 2021, 9:37 AM
Closed by commit rG7445f1e4dcd4: [NFC] Mark Expected<T>::assertIsChecked() as const (authored by xndcn). · Explain WhyJul 8 2021, 6:32 AM
This revision was automatically updated to reflect the committed changes.
xndcn added a commit: rG7445f1e4dcd4: [NFC] Mark Expected<T>::assertIsChecked() as const.

Revision Contents

PathSize
llvm/
include/
llvm/
Support/
2 lines
unittests/
Support/
2 lines

Diff 355902

llvm/include/llvm/Support/Error.h

Context not available.
} }
#endif #endif
void assertIsChecked() { void assertIsChecked() const {
#if LLVM_ENABLE_ABI_BREAKING_CHECKS #if LLVM_ENABLE_ABI_BREAKING_CHECKS
if (LLVM_UNLIKELY(Unchecked)) if (LLVM_UNLIKELY(Unchecked))
fatalUncheckedExpected(); fatalUncheckedExpected();
Context not available.

llvm/unittests/Support/ErrorTest.cpp

Context not available.
// Test runs in debug mode only. // Test runs in debug mode only.
#if LLVM_ENABLE_ABI_BREAKING_CHECKS #if LLVM_ENABLE_ABI_BREAKING_CHECKS
TEST(Error, UncheckedExpectedInSuccessModeAccess) { TEST(Error, UncheckedExpectedInSuccessModeAccess) {
EXPECT_DEATH({ Expected<int> A = 7; *A; }, EXPECT_DEATH({ const Expected<int> A = 7; *A; },
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  EXPECT_DEATH({ const Expected<int> A = 7; *A; },
-               "Expected<T> must be checked before access or destruction.")
-    << "Unchecekd Expected<T> success value did not cause an abort().";
+  EXPECT_DEATH(
+      {
+        const Expected<int> A = 7;
+        *A;
+      },
+      "Expected<T> must be checked before access or destruction.")
+      << "Unchecekd Expected<T> success value did not cause an abort().";
Lint: Pre-merge checks: clang-format: please reformat the code ``` - EXPECT_DEATH({ const Expected<int> A = 7; *A; }…
"Expected<T> must be checked before access or destruction.") "Expected<T> must be checked before access or destruction.")
<< "Unchecekd Expected<T> success value did not cause an abort()."; << "Unchecekd Expected<T> success value did not cause an abort().";
} }
Context not available.
sammccallUnsubmitted
Not Done
ReplyInline Actions

Nit: unchecked (typo)

sammccall: Nit: unchecked (typo)