Page MenuHomePhabricator

xndcn (xndcn)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 24 2020, 6:37 AM (43 w, 15 h)

Recent Activity

Sun, Sep 19

xndcn added a comment to D109805: [mlir][emitc] Fix indent in CondBranchOp and block label.

Add a FXIME comment in emitLabel function:

Sun, Sep 19, 5:09 AM · Restricted Project
xndcn committed rG9de88fc0eac1: [mlir][emitc] Fix indent in CondBranchOp and block label (authored by xndcn).
[mlir][emitc] Fix indent in CondBranchOp and block label
Sun, Sep 19, 5:09 AM
xndcn closed D109805: [mlir][emitc] Fix indent in CondBranchOp and block label.
Sun, Sep 19, 5:08 AM · Restricted Project

Thu, Sep 16

xndcn added a comment to D109805: [mlir][emitc] Fix indent in CondBranchOp and block label.

Thanks! Maybe I can add something like a "UnindentScope"? So we can temporarily print something without any indents.

Thu, Sep 16, 8:14 AM · Restricted Project

Tue, Sep 14

xndcn added inline comments to D109805: [mlir][emitc] Fix indent in CondBranchOp and block label.
Tue, Sep 14, 8:16 PM · Restricted Project
xndcn updated the diff for D109805: [mlir][emitc] Fix indent in CondBranchOp and block label.
Tue, Sep 14, 8:15 PM · Restricted Project
xndcn updated the summary of D109805: [mlir][emitc] Fix indent in CondBranchOp and block label.
Tue, Sep 14, 8:12 PM · Restricted Project
xndcn updated the summary of D109805: [mlir][emitc] Fix indent in CondBranchOp and block label.
Tue, Sep 14, 8:11 PM · Restricted Project
xndcn requested review of D109805: [mlir][emitc] Fix indent in CondBranchOp and block label.
Tue, Sep 14, 7:43 PM · Restricted Project

Jul 8 2021

xndcn committed rG7445f1e4dcd4: [NFC] Mark Expected<T>::assertIsChecked() as const (authored by xndcn).
[NFC] Mark Expected<T>::assertIsChecked() as const
Jul 8 2021, 6:32 AM
xndcn closed D105292: [NFC] Mark Expected<T>::assertIsChecked() as const.
Jul 8 2021, 6:32 AM · Restricted Project

Jul 7 2021

xndcn updated the diff for D105292: [NFC] Mark Expected<T>::assertIsChecked() as const.

@sammccall Thanks! Fixed 3 typo.

Jul 7 2021, 8:21 AM · Restricted Project

Jul 6 2021

xndcn removed a reviewer for D105292: [NFC] Mark Expected<T>::assertIsChecked() as const: lhames.
Jul 6 2021, 8:26 AM · Restricted Project
xndcn edited reviewers for D105292: [NFC] Mark Expected<T>::assertIsChecked() as const, added: sammccall; removed: labath.
Jul 6 2021, 8:26 AM · Restricted Project

Jul 1 2021

xndcn updated the diff for D105292: [NFC] Mark Expected<T>::assertIsChecked() as const.
Jul 1 2021, 10:27 AM · Restricted Project
xndcn requested review of D105292: [NFC] Mark Expected<T>::assertIsChecked() as const.
Jul 1 2021, 9:03 AM · Restricted Project

Dec 15 2020

xndcn added a comment to D92041: [clangd] Add hover info for `this` expr.

Very nice, thanks!
I'll land this for you now.

Dec 15 2020, 9:50 PM · Restricted Project, Restricted Project

Dec 11 2020

xndcn updated the diff for D92041: [clangd] Add hover info for `this` expr.

Thank you, it works like a charm!
For class withou template, getHoverInfo(QualType ...) will add namespace scope by default, so I have to add SuppressScope printpolicy here.

Dec 11 2020, 9:31 AM · Restricted Project, Restricted Project
xndcn added a comment to D92041: [clangd] Add hover info for `this` expr.

Sorry for the delay here. Kadir is out on vacation.

Yikes - it's a shame reusing our existing type printing doesn't do the right thing, but injected-classname and partial specializations are indeed weird.
I'm tempted to say just to live with the "type-parameter-0-0" nonsense rather than implement the workaround, but it's up to you.

Dec 11 2020, 2:18 AM · Restricted Project, Restricted Project

Dec 2 2020

xndcn updated the diff for D92041: [clangd] Add hover info for `this` expr.

getHoverInfo(CXXThisExpr->getType()->getPointeeType(), ...) does not output namespace scope and template parameters without specialization:

Dec 2 2020, 10:00 AM · Restricted Project, Restricted Project

Dec 1 2020

xndcn added a comment to D92041: [clangd] Add hover info for `this` expr.

Thanks, it look more clear really. I'm trying to make the hover looks like auto

Dec 1 2020, 11:57 PM · Restricted Project, Restricted Project
xndcn added a comment to D92041: [clangd] Add hover info for `this` expr.

can you give me an email address to associate the commit with?

Dec 1 2020, 6:14 AM · Restricted Project, Restricted Project

Nov 27 2020

xndcn added a comment to D92041: [clangd] Add hover info for `this` expr.

Do you have commit access or should I commit this for you?

Nov 27 2020, 7:20 PM · Restricted Project, Restricted Project

Nov 26 2020

xndcn updated the diff for D92041: [clangd] Add hover info for `this` expr.

Thanks. Update commit to fix the last nit.

Nov 26 2020, 6:57 PM · Restricted Project, Restricted Project

Nov 25 2020

xndcn updated the diff for D92041: [clangd] Add hover info for `this` expr.

Thanks! Update the commit as review comments.

Nov 25 2020, 7:39 PM · Restricted Project, Restricted Project
xndcn updated the diff for D92041: [clangd] Add hover info for `this` expr.

Update the diff with getHoverContents(const NamedDecl ..) overload function.

Nov 25 2020, 8:25 AM · Restricted Project, Restricted Project
xndcn added inline comments to D92041: [clangd] Add hover info for `this` expr.
Nov 25 2020, 12:48 AM · Restricted Project, Restricted Project
xndcn added inline comments to D92041: [clangd] Add hover info for `this` expr.
Nov 25 2020, 12:02 AM · Restricted Project, Restricted Project

Nov 24 2020

xndcn requested review of D92041: [clangd] Add hover info for `this` expr.
Nov 24 2020, 9:07 AM · Restricted Project, Restricted Project