[llvm-objdump/mac] Print symbols at the same address deterministically

[int3]

Summary

By using stable_sort.

Added a test case which previously failed when expensive checks were
enabled.

[int3]

typo

[MaskRay]

Thanks!

llvm/test/tools/llvm-objdump/MachO/disassemble-symbol-same-addr.test

11

You can add more symbols so that the test can more "deterministically" catch non-determinism.

[int3]

more symbols

llvm/test/tools/llvm-objdump/MachO/disassemble-symbol-same-addr.test

+# RUN: llvm-mc %s --triple x86_64-apple-darwin -filetype=obj -o %t.o
+# RUN: llvm-objdump --macho -d %t.o | FileCheck %s
+
+_foo:
+_bar:
+_baz:
+_qux:
+  nop
+
+## Ensure symbols with the same address are printed in a deterministic order
+# CHECK:      _foo
+# CHECK-NEXT: _bar
+# CHECK-NEXT: _baz
+# CHECK-NEXT: _qux

llvm/tools/llvm-objdump/MachODump.cpp

#undef CHECK_THUMB_TARGET_INFO_CREATION
   std::vector<SymbolRef> Symbols;
   SmallVector<uint64_t, 8> FoundFns;
   uint64_t BaseSegmentAddress = 0;
 
   getSectionsAndSymbols(MachOOF, Sections, Symbols, FoundFns,
                         BaseSegmentAddress);
 
   // Sort the symbols by address, just in case they didn't come in that way.
-  llvm::sort(Symbols, SymbolSorter());
+  llvm::stable_sort(Symbols, SymbolSorter());
 
   // Build a data in code table that is sorted on by the address of each entry.
   uint64_t BaseAddress = 0;
   if (Header.filetype == MachO::MH_OBJECT)
     BaseAddress = Sections[0].getAddress();
   else
     BaseAddress = BaseSegmentAddress;
   DiceTable Dices;