[OpenMP] Increase attributor iterations on the GPU

[jhuber6]

Summary

Increase the number of attributor iterations on a GPU target. I forgot to
change this in D104416.

[jdoerfert]

LG. Please clang format. Since this was already discussed and approved, feel free to submit such things.

[DavidSpickett]

llvm/lib/Transforms/IPO/OpenMPOpt.cpp

2671

Building with GCC I get a warning here:

llvm-project/llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2671:37: warning: address of function 'isOpenMPDevice' will always evaluate to 'true' [-Wpointer-bool-conversion]
  unsigned MaxFixponitIterations = (isOpenMPDevice) ? 128 : 32;
                                    ^~~~~~~~~~~~~~  ~
/home/david.spickett/llvm-project/llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2671:37: note: prefix with the address-of operator to silence this warning
  unsigned MaxFixponitIterations = (isOpenMPDevice) ? 128 : 32;
                                    ^
                                    &

Also going by the patch before this it should be MaxFixpointIterations. ponit -> point

[jhuber6]

llvm/lib/Transforms/IPO/OpenMPOpt.cpp

2671

Should be fixed upstream, thanks for pointing out the typo.

llvm/lib/Transforms/IPO/OpenMPOpt.cpp

PreservedAnalyses OpenMPOptPass::run(Module &M, ModuleAnalysisManager &AM) {
   };
 
   BumpPtrAllocator Allocator;
   CallGraphUpdater CGUpdater;
 
   SetVector<Function *> Functions(SCC.begin(), SCC.end());
   OMPInformationCache InfoCache(M, AG, Allocator, /*CGSCC*/ Functions, Kernels);
 
-  unsigned MaxFixponitIterations = (Kernels.empty()) ? 64 : 32;
-  Attributor A(Functions, InfoCache, CGUpdater, nullptr, true, false, MaxFixponitIterations, OREGetter,
-               DEBUG_TYPE);
+  unsigned MaxFixponitIterations = (isOpenMPDevice) ? 128 : 32;
+  Attributor A(Functions, InfoCache, CGUpdater, nullptr, true, false,
+               MaxFixponitIterations, OREGetter, DEBUG_TYPE);
 
   OpenMPOpt OMPOpt(SCC, CGUpdater, OREGetter, InfoCache, A);
   bool Changed = OMPOpt.run(true);
   if (Changed)
     return PreservedAnalyses::none();
 
   return PreservedAnalyses::all();
 }
PreservedAnalyses OpenMPOptCGSCCPass::run(LazyCallGraph::SCC &C,
   BumpPtrAllocator Allocator;
   CallGraphUpdater CGUpdater;
   CGUpdater.initialize(CG, C, AM, UR);
 
   SetVector<Function *> Functions(SCC.begin(), SCC.end());
   OMPInformationCache InfoCache(*(Functions.back()->getParent()), AG, Allocator,
                                 /*CGSCC*/ Functions, Kernels);
 
-  unsigned MaxFixponitIterations = (isOpenMPDevice(M)) ? 64 : 32;
-  Attributor A(Functions, InfoCache, CGUpdater, nullptr, false, true, MaxFixponitIterations, OREGetter,
-               DEBUG_TYPE);
+  unsigned MaxFixponitIterations = (isOpenMPDevice(M)) ? 128 : 32;
+  Attributor A(Functions, InfoCache, CGUpdater, nullptr, false, true,
+               MaxFixponitIterations, OREGetter, DEBUG_TYPE);
 
   OpenMPOpt OMPOpt(SCC, CGUpdater, OREGetter, InfoCache, A);
   bool Changed = OMPOpt.run(false);
   if (Changed)
     return PreservedAnalyses::none();
 
   return PreservedAnalyses::all();
 }
bool runOnSCC(CallGraphSCC &CGSCC) override {
 
     AnalysisGetter AG;
     SetVector<Function *> Functions(SCC.begin(), SCC.end());
     BumpPtrAllocator Allocator;
     OMPInformationCache InfoCache(*(Functions.back()->getParent()), AG,
                                   Allocator,
                                   /*CGSCC*/ Functions, Kernels);
 
-    unsigned MaxFixponitIterations = (isOpenMPDevice(M)) ? 64 : 32;
+    unsigned MaxFixponitIterations = (isOpenMPDevice(M)) ? 128 : 32;
     Attributor A(Functions, InfoCache, CGUpdater, nullptr, false, true,
                  MaxFixponitIterations, OREGetter, DEBUG_TYPE);
 
     OpenMPOpt OMPOpt(SCC, CGUpdater, OREGetter, InfoCache, A);
     return OMPOpt.run(false);
   }
 
   bool doFinalization(CallGraph &CG) override { return CGUpdater.finalize(); }