This is an archive of the discontinued LLVM Phabricator instance.

[LLD][ELF][ARM] Tidy up test to hook up missing filecheck patterns [NFC]
ClosedPublic

Authored by peter.smith on Jun 25 2021, 4:33 AM.

Details

Summary

A couple of filecheck patterns had not been hooked up with the patterns suffering from some drift. As this test is old and llvm-objdump has improved a lot, take this opportunity to hide the instruction encoding. I've also taken out a lot of the explanatory comments that llvm-objdump improvements make redundant, as these comments oftern don't get updated when addresses change.

Depends on D104701 for objdump improvements

Diff Detail

Event Timeline

peter.smith created this revision.Jun 25 2021, 4:33 AM
peter.smith requested review of this revision.Jun 25 2021, 4:33 AM
MaskRay accepted this revision.Jun 26 2021, 10:40 AM

Looks great!

This revision is now accepted and ready to land.Jun 26 2021, 10:40 AM
ikudrin requested changes to this revision.Jun 28 2021, 2:36 AM
ikudrin added inline comments.
lld/test/ELF/arm-thumb-interwork-thunk.s
290

It looks like the CHECK-PI-ARM-PLT block is not checked.

This revision now requires changes to proceed.Jun 28 2021, 2:36 AM

Thanks for the spot. I've consolidated all the checks around CHECK-ARM-PLT.

ikudrin accepted this revision.Jun 29 2021, 4:02 AM

LGTM

This revision is now accepted and ready to land.Jun 29 2021, 4:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2021, 6:17 AM