Page MenuHomePhabricator

Reland "[AArch64] handle -Wa,-march="
AbandonedPublic

Authored by jcai19 on Jun 21 2021, 10:15 AM.

Details

Summary

This relands commit fd11a26d368c5a909fb88548fef2cee7a6c2c931, which was
reverted by 9145a3d4ab7eb05d9fb113b5392e8961df629b88 due to a test
failure on aarch64 backend, e.g.
https://lab.llvm.org/buildbot/#/builders/43/builds/7031. This patch
fixed the test failure.

Diff Detail

Event Timeline

jcai19 created this revision.Jun 21 2021, 10:15 AM
jcai19 requested review of this revision.Jun 21 2021, 10:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2021, 10:15 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

This reverts commit fd11a26d368c5a909fb88548fef2cee7a6c2c931

Shouldn't that be This relands commit fd11a26d368c5a909fb88548fef2cee7a6c2c931?

It's pretty hard to see what's different in this new version since the original, can you comment on how you fixed the issue?

jcai19 edited the summary of this revision. (Show Details)Jun 21 2021, 10:49 AM
jcai19 updated this revision to Diff 353431.Jun 21 2021, 11:17 AM

Add comments explaning the difference with D103184. The implementation in D103184 unconditionally calls getAArch64ArchFeaturesFromMarch, which returns false when an irrelevant -Wa value is detected and parsed (e.g. -Wa,--version) and causes Clang to bail out.

This reverts commit fd11a26d368c5a909fb88548fef2cee7a6c2c931

Shouldn't that be This relands commit fd11a26d368c5a909fb88548fef2cee7a6c2c931?

Done. Thanks for noticing the typo.

jcai19 abandoned this revision.Jun 21 2021, 11:35 AM