This is an archive of the discontinued LLVM Phabricator instance.

[vscode-mlir] Add support for restarting the server on setting/server changes
ClosedPublic

Authored by rriddle on Jun 17 2021, 6:45 PM.

Details

Summary

This revision adds detection for changes to either the mlir-lsp-server binary or the setting, and prompts the user to restart the server. Whether the user gets prompted or not is a configurable setting in the extension, and this setting may updated based on the user response to the prompt.

Diff Detail

Event Timeline

rriddle created this revision.Jun 17 2021, 6:45 PM
rriddle requested review of this revision.Jun 17 2021, 6:45 PM
jpienaar accepted this revision.Jun 26 2021, 8:28 AM
jpienaar added inline comments.
mlir/utils/vscode/package.json
51

Action when setting change necessitates server ?

it feels like the tense of this description is different than the others [just suggestion]

58

Are these shown as options of the above heading? If so then one could take advantage of the context rather than repeating

This revision is now accepted and ready to land.Jun 26 2021, 8:28 AM
rriddle marked 2 inline comments as done.Jun 28 2021, 3:45 PM
rriddle added inline comments.
mlir/utils/vscode/package.json
58

They are shown as a description when changing the option in the settings menu, as well as the JSON. The context of the setting option isn't always visible, so the redundancy is somewhat desirable. (And common, see the example under enum / enumDescriptions within https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema

rriddle updated this revision to Diff 355056.Jun 28 2021, 3:59 PM
rriddle marked an inline comment as done.

update

This revision was landed with ongoing or failed builds.Jun 28 2021, 5:09 PM
This revision was automatically updated to reflect the committed changes.