Page MenuHomePhabricator

[llvm] Fix lto tests that requires ld64
ClosedPublic

Authored by steven_wu on Jun 15 2021, 4:18 PM.

Details

Summary

Since Xcode 13, ld64 requires linking libSystem for all the executable.
Fix the tests that needs to run ld64 by linking libSystem from sysroot.

rdar://77332728

Diff Detail

Event Timeline

steven_wu created this revision.Jun 15 2021, 4:18 PM
steven_wu requested review of this revision.Jun 15 2021, 4:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2021, 4:18 PM
fhahn accepted this revision.Jun 16 2021, 10:09 AM

LGTM thanks for the fix Steven!

This revision is now accepted and ready to land.Jun 16 2021, 10:09 AM
This revision was automatically updated to reflect the committed changes.

FYI: This adds an absolute path to the generated lit.site.cfg.py. We made it possible to build on one machine and then run tests on another machine a while ago (…as long as your build dir is below your checkout dir), and this breaks that. I tried to fix this up in dedeb661911188a.