symbolOperands were completely ignored by SimplifyAllocConst. Also, I dindn't find any tests for this pattern. Also, slightly improved diagnostic message for verifyAllocLikeOp.
Thanks for fixing this. Some minor comments.
This is incorrectly named - should be dynamicSizes.
operand -> dynamicSize
There are tests for this pattern but they are in test/Transforms/canonicalize.mlir - @alloc_const_fold. Can you bring that test case here and keep either that or this?
Nit: ignore_symbols -> with_symbols ?