This is an archive of the discontinued LLVM Phabricator instance.

Differential D104233

[mlir] ODS: do not emit trailing const for static methods
ClosedPublic

Authored by ftynse on Jun 14 2021, 8:20 AM.

Details

Reviewers
rriddle
antiagainst
Commits
rG8ed88559582f: [mlir] ODS: do not emit trailing const for static methods
Summary

The generated C++ would be invalid.

Diff Detail

Event Timeline

ftynse created this revision.Jun 14 2021, 8:20 AM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptJun 14 2021, 8:20 AM
ftynse requested review of this revision.Jun 14 2021, 8:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 8:20 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ftynse added reviewers: rriddle, antiagainst.Jun 14 2021, 8:22 AM
ftynse added a child revision: D104234: [mlir] separable registration of attribute and type interfaces.Jun 14 2021, 8:22 AM
Harbormaster completed remote builds in B109111: Diff 351886.Jun 14 2021, 8:56 AM
rriddle accepted this revision.Jun 14 2021, 11:15 AM

Nice, thanks!

This revision is now accepted and ready to land.Jun 14 2021, 11:15 AM
Closed by commit rG8ed88559582f: [mlir] ODS: do not emit trailing const for static methods (authored by ftynse). · Explain WhyJun 15 2021, 4:34 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rG8ed88559582f: [mlir] ODS: do not emit trailing const for static methods.

Revision Contents

PathSize
mlir/
tools/
mlir-tblgen/
2 lines

Diff 352095

mlir/tools/mlir-tblgen/OpInterfacesGen.cpp

Show First 20 Lines • Show All 319 Lines • ▼ Show 20 Lines if (method.getName() == "verifyTrait")
interfaceName)); interfaceName));
auto defaultImpl = method.getDefaultImplementation(); auto defaultImpl = method.getDefaultImplementation();
if (!defaultImpl) if (!defaultImpl)
continue; continue;
os << " " << (method.isStatic() ? "static " : ""); os << " " << (method.isStatic() ? "static " : "");
emitCPPType(method.getReturnType(), os); emitCPPType(method.getReturnType(), os);
emitMethodNameAndArgs(method, os, valueType, /*addThisArg=*/false, emitMethodNameAndArgs(method, os, valueType, /*addThisArg=*/false,
/*addConst=*/!isOpInterface); /*addConst=*/!isOpInterface && !method.isStatic());
os << " {\n " << tblgen::tgfmt(defaultImpl->trim(), &traitMethodFmt) os << " {\n " << tblgen::tgfmt(defaultImpl->trim(), &traitMethodFmt)
<< "\n }\n"; << "\n }\n";
} }
if (auto verify = interface.getVerify()) { if (auto verify = interface.getVerify()) {
assert(isa<OpInterface>(interface) && "only OpInterface supports 'verify'"); assert(isa<OpInterface>(interface) && "only OpInterface supports 'verify'");
tblgen::FmtContext verifyCtx; tblgen::FmtContext verifyCtx;
▲ Show 20 Lines • Show All 155 Lines • Show Last 20 Lines