This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fixed dynamic operand storage on big-endian machines.
ClosedPublic

Authored by imaihal on Jun 14 2021, 6:54 AM.

Details

Summary

Many tests fails by D101969 (https://reviews.llvm.org/D101969)
on big-endian machines. This patch changes bit order of
TrailingOperandStorage in big-endian machines. This patch
works on System Z (Triple = "s390x-ibm-linux", CPU = "z14").

Signed-off-by: Haruki Imai <imaihal@jp.ibm.com>

Diff Detail

Event Timeline

imaihal created this revision.Jun 14 2021, 6:54 AM
imaihal requested review of this revision.Jun 14 2021, 6:54 AM
imaihal updated this revision to Diff 351883.Jun 14 2021, 8:17 AM

Fixed #ifdef.

rriddle accepted this revision.Jun 14 2021, 11:22 AM

Nice, thanks for the fix!

This revision is now accepted and ready to land.Jun 14 2021, 11:22 AM

@rriddle Thanks for quick review! I don't have commit access. So, could you land this patch?

This revision was automatically updated to reflect the committed changes.