@rriddle Thanks for quick review! I don't have commit access. So, could you land this patch?

Fixed #ifdef.

Rebased.
Could you land this patch?

@bondhugula Much appreciate your reviews!

@bondhugula Thanks for the review! I updated the code. Do you have any other comments?

Reflected comments.

Hi, @rriddle , I got many testing errors after this patch on Systems Z (Big-endian machine)(Triple = "s390x-ibm-linux", CPU = "z14").
It seems I can avoid the errors by changing the bit order (TrailingOperandStorage() : numOperands(0), capacity(0), reserved(0) {}) , but I'm not sure why.
Do you have any suggestion?

Rebased and removed unnecessary include file.

In D93592#2715960, @imaihal wrote:

Hi, @ezhulenev
I'm testing MLIR on System z (Triple = "s390x-ibm-linux", CPU = "z14"), but I realized installation test (cmake --build . --target check-mlir) failed after this patch.
Endianness of System z is big-endian. Do you think this patch depends on the endianness? Do you have any suggestions to fix this?

Used output parameters to reflect comments.

Hi, @bondhugula , I updated this patch to reflect your suggestions. How do you think of this?

Rebased.

In D93592#2717318, @ezhulenev wrote:

Can the problem be in calculation of the value storage size?

Hi, @ezhulenev
I'm testing MLIR on System z (Triple = "s390x-ibm-linux", CPU = "z14"), but I realized installation test (cmake --build . --target check-mlir) failed after this patch.
Endianness of System z is big-endian. Do you think this patch depends on the endianness? Do you have any suggestions to fix this?

@bondhugula I updated the patch.

Fixed errors in clang-tidy.

Updated check routine for a tiled layout. It checks dimensions being floordiv'ed and then those same dimensions appearing with a mod and no other expressions involving those dimensions. Also, the routine provides those tile sizes back to the call site.

Reflected comments for isTiledLayoutMap().

Rebased.

Updated to solve warning message in clang-tidy and rebased.

Updated condition of tiled-layout map used in isTiledLayoutMap()

@mehdi_amini Thanks for review. I don't have commit access. Could you commit this patch?

@bondhugula Thanks for your review! I reflected your comments. Could you review again?

Fixed a comment.

Fixed code that accidentally deleted a previous fix, and updated comments.

Rebased and reflected comments.

@bondhugula @avarmapml Sorry again, but I would like to use this patch in my use case. Could you merge this if you can approve?

@bondhugula @avarmapml Thanks for your review! I reflected your comments. Do you have additional comments?

Removed canonicalize.

Reflected comments.

@bondhugula @avarmapml Thanks for your review! I reflected your comments. Do you have any other comments on this?

Rebased.

@bondhugula @avarmapml Thanks for your reviews! I reflected your comments.

Rebased and Reflected comments.

Clean up.

@rriddle Thanks for reviewing many times! I don't have commit access. Could you commit this patch if you don't have any other comments?

Hi, @rriddle, do you have any comments on this patch?

In D88719#2381285, @bondhugula wrote:

Looks good. Please address the remaining minor comments.

Rebased and reflected comments.

In D80272#2090239, @rriddle wrote:

Can you try Eli's suggestion in this patch?

Updated comments and inserted assert.

Use ulittle for eidian conversion.

Reflected the comment.

@rriddle Thanks for your review. I don't have commit access. If you don't have other comments, could you commit this patch?

Avoid warning message.

Avoid warning in assert().

Rebased.

Reflect comments.

@rriddle Thanks for your comments. I answered some of the comments.

Reflected comments and rebased.

Removed unnecessary headers.

Moved the convEndianBE into DenseIntOrFPElementsAttr class and removed EndianUtilities.

@mehdi_amini Thanks for your review! I reflected all of your comments.

Reflected @mehdi_amini's comments.

Implemented the conversion from LE to BE in AttributeParser and from BE to LE in AsmPrinter
, assuming that HEX in dense.attr is always LE.

@bondhugula @avarmapml Thanks for your comments! I updated the code to reflect your comments. I moved part of code in the lambda to Util.cpp. Could you review again?

Rebased and fixed a comment.

Updated test case to include two operation results.

Reflected comments and rebased.

@bondhugula @avarmapml I found the results(returend memref) of normalizable operation were not normalized by --normalize-memrefs.
In test case, %1 was not normalized. This patch fixes it.
%1 = "test.op_norm_ret"(%arg0, %arg1) : (memref<1x32768xf32>, memref<1x16x14x14xf32, #map1>) -> (memref<1x16x14x14xf32, #map1>)

Fix to remove warning message (newOp -> *newOp)

Rebased

@bondhugula It seems there is no additional comments. Could you commit also this patch?

@AlexEichenberger

glad to see that the traits make such changes easy...

Yes. The traits are very useful. We might need to add them in other ops depending on use-case, but it is easy.

Reflected the comment about map, and rebased

When we use load and store ops like the test in this patch, the --normalize-memrefs does not work. This patch fix it by adding MemRefsNormalizable trait in load and store ops.
If we can use affine.load and affine.store in this test, the normalization works, but sometimes affine.load can not be used. In the case, we need to use std.load.

@bondhugula @AlexEichenberger @avarmapml Do you have any other comments?

Updated comments and rename test func

Fixed comments and format

Rebased

Sorry, I may did wrong operaton... I will fix this.

Rebased and rephrased the comment.

@bondhugula @avarmapml Thanks for your comments! I added test and comments, and renamed the variables to reflect @bondhugula 's comments.