Page MenuHomePhabricator

imaihal (Haruki Imai)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2020, 10:42 PM (115 w, 3 d)

Recent Activity

Aug 10 2021

imaihal added a comment to D107425: [mlir] Support normalizing memrefs with MemRef_ReinterpretCastOp.

@bondhugula Thanks for your review! I don't have commit access. So, could you land this patch?

Aug 10 2021, 9:03 AM · Restricted Project

Aug 9 2021

imaihal added inline comments to D107425: [mlir] Support normalizing memrefs with MemRef_ReinterpretCastOp.
Aug 9 2021, 9:21 PM · Restricted Project

Aug 7 2021

imaihal added a comment to D107425: [mlir] Support normalizing memrefs with MemRef_ReinterpretCastOp.

@bondhugula Sorry again. Could you be a reviewer of this patch?

Aug 7 2021, 7:57 AM · Restricted Project

Aug 3 2021

imaihal updated subscribers of D107425: [mlir] Support normalizing memrefs with MemRef_ReinterpretCastOp.

@bondhugula I would like to support normalizing memrefs with MemRef_ReinterpretCastOp. As usual, this patch adds MemRefNormalizable trait. Could you review this patch?

Aug 3 2021, 11:19 PM · Restricted Project
imaihal requested review of D107425: [mlir] Support normalizing memrefs with MemRef_ReinterpretCastOp.
Aug 3 2021, 11:10 PM · Restricted Project

Jul 8 2021

imaihal added a comment to D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..

@MaskRay Yes. New GCC (>= 10.3) works.

Jul 8 2021, 9:33 PM · Restricted Project
imaihal updated the diff for D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..

Updated the comment again to reflect @MaskRay`s comment.

Jul 8 2021, 8:49 PM · Restricted Project
imaihal updated the diff for D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..

Updated the comment. We confirmed GCC version >= 10.3 works, not >= 11.

Jul 8 2021, 8:39 PM · Restricted Project
imaihal added a comment to D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..

@MaskRay Thanks for comments.

Jul 8 2021, 8:02 PM · Restricted Project
imaihal updated the summary of D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..
Jul 8 2021, 7:54 PM · Restricted Project
imaihal updated the diff for D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..

Removed checking for MLIR build. Now the option is disabled for all configuration of SystemZ.

Jul 8 2021, 7:53 PM · Restricted Project

Jul 7 2021

imaihal updated the summary of D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..
Jul 7 2021, 8:18 AM · Restricted Project
imaihal updated the diff for D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..

Updated the condition to disable the option. It is disabled when GCC version is less than 10.3.

Jul 7 2021, 7:49 AM · Restricted Project
imaihal updated subscribers of D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..

I don't mind. I suspect there is a gcc SystemZ bug but I don't have access to a SystemZ machine.
Worth filing a gcc bug if you can spend more time on investigating the issue.

Jul 7 2021, 1:17 AM · Restricted Project
imaihal retitled D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option. from [mlir][System_Z] Disable `-fno-semantic-interposition` option. to [mlir][SystemZ] Disable `-fno-semantic-interposition` option..
Jul 7 2021, 1:08 AM · Restricted Project
imaihal updated the diff for D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..

Condition to disable the option was updated since we found GCC version >= 11 is no problem.

Jul 7 2021, 1:07 AM · Restricted Project

Jul 6 2021

imaihal updated subscribers of D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..

After D102453, MLIR installation test (cmake --build . --target check-mlir) issues 32 errors on SystemZ with GCC. This errors can be avoided by disabling fno-semantic-interposition. I used g++ (Ubuntu 9.4.0-1ubuntu1~18.04) 9.4.0.

Jul 6 2021, 1:08 AM · Restricted Project

Jul 5 2021

imaihal requested review of D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option..
Jul 5 2021, 7:19 PM · Restricted Project

Jun 15 2021

imaihal added a comment to D104225: [mlir] Fixed dynamic operand storage on big-endian machines..

@rriddle Thanks for quick review! I don't have commit access. So, could you land this patch?

Jun 15 2021, 7:04 PM · Restricted Project

Jun 14 2021

imaihal updated the diff for D104225: [mlir] Fixed dynamic operand storage on big-endian machines..

Fixed #ifdef.

Jun 14 2021, 8:17 AM · Restricted Project
imaihal requested review of D104225: [mlir] Fixed dynamic operand storage on big-endian machines..
Jun 14 2021, 6:54 AM · Restricted Project

May 20 2021

imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Rebased.
Could you land this patch?

May 20 2021, 6:49 AM · Restricted Project

May 14 2021

imaihal added a comment to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

@bondhugula Much appreciate your reviews!

May 14 2021, 12:00 AM · Restricted Project

May 12 2021

imaihal added a comment to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

@bondhugula Thanks for the review! I updated the code. Do you have any other comments?

May 12 2021, 8:16 AM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Reflected comments.

May 12 2021, 7:23 AM · Restricted Project

May 11 2021

imaihal added a comment to D101969: [mlir] Store the flag for dynamic operand storage in the low bits.

Hi, @rriddle , I got many testing errors after this patch on Systems Z (Big-endian machine)(Triple = "s390x-ibm-linux", CPU = "z14").
It seems I can avoid the errors by changing the bit order (TrailingOperandStorage() : numOperands(0), capacity(0), reserved(0) {}) , but I'm not sure why.
Do you have any suggestion?

May 11 2021, 9:07 AM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Rebased and removed unnecessary include file.

May 11 2021, 1:04 AM · Restricted Project

May 10 2021

imaihal added a comment to D93592: [mlir] Async: lowering async.value to LLVM.

Hi, @ezhulenev
I'm testing MLIR on System z (Triple = "s390x-ibm-linux", CPU = "z14"), but I realized installation test (cmake --build . --target check-mlir) failed after this patch.
Endianness of System z is big-endian. Do you think this patch depends on the endianness? Do you have any suggestions to fix this?

May 10 2021, 7:21 PM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Used output parameters to reflect comments.

May 10 2021, 7:16 AM · Restricted Project

May 4 2021

imaihal added a comment to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Hi, @bondhugula , I updated this patch to reflect your suggestions. How do you think of this?

May 4 2021, 8:24 AM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Rebased.

May 4 2021, 7:25 AM · Restricted Project

Apr 26 2021

imaihal added a comment to D93592: [mlir] Async: lowering async.value to LLVM.

Can the problem be in calculation of the value storage size?

Apr 26 2021, 7:57 PM · Restricted Project

Apr 25 2021

imaihal added a comment to D93592: [mlir] Async: lowering async.value to LLVM.

Hi, @ezhulenev
I'm testing MLIR on System z (Triple = "s390x-ibm-linux", CPU = "z14"), but I realized installation test (cmake --build . --target check-mlir) failed after this patch.
Endianness of System z is big-endian. Do you think this patch depends on the endianness? Do you have any suggestions to fix this?

Apr 25 2021, 11:47 PM · Restricted Project

Apr 22 2021

imaihal added a comment to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

@bondhugula I updated the patch.

Apr 22 2021, 10:01 PM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Fixed errors in clang-tidy.

Apr 22 2021, 7:16 PM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Updated check routine for a tiled layout. It checks dimensions being floordiv'ed and then those same dimensions appearing with a mod and no other expressions involving those dimensions. Also, the routine provides those tile sizes back to the call site.

Apr 22 2021, 8:13 AM · Restricted Project

Apr 19 2021

imaihal added inline comments to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..
Apr 19 2021, 8:14 PM · Restricted Project
imaihal added inline comments to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..
Apr 19 2021, 7:56 PM · Restricted Project
imaihal added inline comments to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..
Apr 19 2021, 8:37 AM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Reflected comments for isTiledLayoutMap().

Apr 19 2021, 8:23 AM · Restricted Project

Apr 15 2021

imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Rebased.

Apr 15 2021, 12:17 AM · Restricted Project

Apr 14 2021

imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Updated to solve warning message in clang-tidy and rebased.

Apr 14 2021, 6:03 PM · Restricted Project

Apr 13 2021

imaihal added inline comments to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..
Apr 13 2021, 11:51 PM · Restricted Project
imaihal updated the summary of D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..
Apr 13 2021, 11:48 PM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Updated condition of tiled-layout map used in isTiledLayoutMap()

Apr 13 2021, 11:47 PM · Restricted Project

Apr 7 2021

imaihal added a comment to D99882: [mlir] Fixed alighnment attribute of alloc constant folding..

@mehdi_amini Thanks for review. I don't have commit access. Could you commit this patch?

Apr 7 2021, 12:27 AM · Restricted Project

Apr 5 2021

imaihal added a comment to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

@bondhugula Thanks for your review! I reflected your comments. Could you review again?

Apr 5 2021, 6:30 PM · Restricted Project
imaihal requested review of D99882: [mlir] Fixed alighnment attribute of alloc constant folding..
Apr 5 2021, 7:02 AM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Fixed a comment.

Apr 5 2021, 1:33 AM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Fixed code that accidentally deleted a previous fix, and updated comments.

Apr 5 2021, 1:26 AM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Rebased and reflected comments.

Apr 5 2021, 12:35 AM · Restricted Project

Mar 29 2021

imaihal added a comment to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

@bondhugula @avarmapml Sorry again, but I would like to use this patch in my use case. Could you merge this if you can approve?

Mar 29 2021, 6:47 AM · Restricted Project

Mar 22 2021

imaihal added a comment to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

@bondhugula @avarmapml Thanks for your review! I reflected your comments. Do you have additional comments?

Mar 22 2021, 4:51 PM · Restricted Project

Mar 18 2021

imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Removed canonicalize.

Mar 18 2021, 12:06 AM · Restricted Project

Mar 17 2021

imaihal added inline comments to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..
Mar 17 2021, 9:51 PM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Reflected comments.

Mar 17 2021, 9:32 PM · Restricted Project

Mar 9 2021

imaihal added a comment to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

@bondhugula @avarmapml Thanks for your review! I reflected your comments. Do you have any other comments on this?

Mar 9 2021, 6:03 PM · Restricted Project

Mar 4 2021

imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Rebased.

Mar 4 2021, 7:10 AM · Restricted Project

Mar 2 2021

imaihal added a comment to D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

@bondhugula @avarmapml Thanks for your reviews! I reflected your comments.

Mar 2 2021, 6:33 AM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Rebased and Reflected comments.

Mar 2 2021, 6:31 AM · Restricted Project

Feb 28 2021

imaihal retitled D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout. from Normalize dynamic memrefs with a map of tiled-layout. to [mlir] Normalize dynamic memrefs with a map of tiled-layout..
Feb 28 2021, 9:57 PM · Restricted Project
imaihal updated the diff for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..

Clean up.

Feb 28 2021, 8:55 PM · Restricted Project
imaihal retitled D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout. from Normalize dynamic memrefs with a map with tiled-layout. to Normalize dynamic memrefs with a map of tiled-layout..
Feb 28 2021, 6:49 PM · Restricted Project
imaihal added a reviewer for D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout.: bondhugula.
Feb 28 2021, 6:48 PM · Restricted Project
imaihal requested review of D97655: [mlir] Normalize dynamic memrefs with a map of tiled-layout..
Feb 28 2021, 6:47 PM · Restricted Project

Nov 17 2020

imaihal added a comment to D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

@rriddle Thanks for reviewing many times! I don't have commit access. Could you commit this patch if you don't have any other comments?

Nov 17 2020, 1:13 AM · Restricted Project, Restricted Project

Nov 15 2020

imaihal added a comment to D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Hi, @rriddle, do you have any comments on this patch?

Nov 15 2020, 10:15 PM · Restricted Project, Restricted Project

Nov 10 2020

imaihal added a comment to D88719: [mlir] Normalize the results of normalizable operations.

Looks good. Please address the remaining minor comments.

Nov 10 2020, 10:22 PM · Restricted Project
imaihal added inline comments to D88719: [mlir] Normalize the results of normalizable operations.
Nov 10 2020, 10:04 PM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Rebased and reflected comments.

Nov 10 2020, 10:00 PM · Restricted Project

Nov 1 2020

imaihal added a comment to D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Can you try Eli's suggestion in this patch?

Nov 1 2020, 6:42 PM · Restricted Project, Restricted Project

Oct 31 2020

imaihal updated the summary of D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
Oct 31 2020, 9:00 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Updated comments and inserted assert.

Oct 31 2020, 8:49 AM · Restricted Project, Restricted Project

Oct 30 2020

imaihal updated the diff for D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Use ulittle for eidian conversion.

Oct 30 2020, 10:10 AM · Restricted Project, Restricted Project

Oct 28 2020

imaihal added inline comments to D88719: [mlir] Normalize the results of normalizable operations.
Oct 28 2020, 8:38 AM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Reflected the comment.

Oct 28 2020, 8:35 AM · Restricted Project

Oct 27 2020

imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

@rriddle Thanks for your review. I don't have commit access. If you don't have other comments, could you commit this patch?

Oct 27 2020, 9:03 PM · Restricted Project, Restricted Project
imaihal added inline comments to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 27 2020, 8:57 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Avoid warning message.

Oct 27 2020, 8:16 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Avoid warning in assert().

Oct 27 2020, 7:45 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Rebased.

Oct 27 2020, 8:56 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Reflect comments.

Oct 27 2020, 7:44 AM · Restricted Project, Restricted Project

Oct 26 2020

imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

@rriddle Thanks for your comments. I answered some of the comments.

Oct 26 2020, 6:58 PM · Restricted Project, Restricted Project
imaihal added inline comments to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 26 2020, 7:49 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Reflected comments and rebased.

Oct 26 2020, 7:41 AM · Restricted Project, Restricted Project

Oct 20 2020

imaihal added inline comments to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 20 2020, 11:18 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Removed unnecessary headers.

Oct 20 2020, 11:13 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Moved the convEndianBE into DenseIntOrFPElementsAttr class and removed EndianUtilities.

Oct 20 2020, 10:48 PM · Restricted Project, Restricted Project
imaihal updated the summary of D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 20 2020, 7:00 AM · Restricted Project, Restricted Project
imaihal retitled D80695: [mlir] Convert raw data in dense element attributes for big-endian machines. from [mlir] Convert raw data in dense element attributes into big-endian format. to [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 20 2020, 6:48 AM · Restricted Project, Restricted Project
imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

@mehdi_amini Thanks for your review! I reflected all of your comments.

Oct 20 2020, 6:30 AM · Restricted Project, Restricted Project
imaihal added inline comments to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 20 2020, 6:29 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Reflected @mehdi_amini's comments.

Oct 20 2020, 6:21 AM · Restricted Project, Restricted Project

Oct 19 2020

imaihal retitled D80695: [mlir] Convert raw data in dense element attributes for big-endian machines. from [mlir] Added big endian version of "dense-elements-hex.mlir" to [mlir] Convert raw data in dense element attributes into big-endian format..
Oct 19 2020, 8:54 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Implemented the conversion from LE to BE in AttributeParser and from BE to LE in AsmPrinter
, assuming that HEX in dense.attr is always LE.

Oct 19 2020, 8:52 AM · Restricted Project, Restricted Project

Oct 5 2020

imaihal added a comment to D88719: [mlir] Normalize the results of normalizable operations.

@bondhugula @avarmapml Thanks for your comments! I updated the code to reflect your comments. I moved part of code in the lambda to Util.cpp. Could you review again?

Oct 5 2020, 5:46 PM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Rebased and fixed a comment.

Oct 5 2020, 5:42 PM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Updated test case to include two operation results.

Oct 5 2020, 9:09 AM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Reflected comments and rebased.

Oct 5 2020, 12:13 AM · Restricted Project

Oct 2 2020

imaihal updated subscribers of D88719: [mlir] Normalize the results of normalizable operations.

@bondhugula @avarmapml I found the results(returend memref) of normalizable operation were not normalized by --normalize-memrefs.
In test case, %1 was not normalized. This patch fixes it.
%1 = "test.op_norm_ret"(%arg0, %arg1) : (memref<1x32768xf32>, memref<1x16x14x14xf32, #map1>) -> (memref<1x16x14x14xf32, #map1>)

Oct 2 2020, 2:23 PM · Restricted Project