Page MenuHomePhabricator

imaihal (Haruki Imai)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2020, 10:42 PM (6 w, 11 h)

Recent Activity

Wed, May 20

imaihal updated the diff for D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Fixed variable name to meet camelBack style

Wed, May 20, 7:53 PM · Restricted Project
imaihal updated the summary of D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
Wed, May 20, 7:53 PM · Restricted Project
imaihal updated the summary of D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
Wed, May 20, 7:53 PM · Restricted Project

Tue, May 19

imaihal created D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
Tue, May 19, 11:57 PM · Restricted Project
imaihal added a comment to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

@ftynse and @mehdi_amini, Could you help to commit this if this patch ready for commit? I don't have write access to the repository.

Tue, May 19, 7:16 PM · Restricted Project
imaihal added inline comments to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.
Tue, May 19, 6:13 PM · Restricted Project
imaihal updated the diff for D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

Changed getHostCPUName() part to reflect the comment.

Tue, May 19, 6:11 PM · Restricted Project

Mon, May 18

imaihal added a comment to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

My wrong operation(submission) may add LLDB tag on this patch.

Mon, May 18, 8:04 PM · Restricted Project
imaihal added a comment to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

Thanks for the review! I changed the variable name to camelBack

Mon, May 18, 8:04 PM · Restricted Project
imaihal updated the diff for D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.
  • [NFC] Replace MaybeAlign with Align in TargetTransformInfo.
  • [mlir][SystemZ] Fix incompatible datalayout in SystemZ
Mon, May 18, 8:04 PM · Restricted Project
imaihal updated the diff for D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

[mlir][SystemZ] Fix incompatible datalayout in SystemZ

Mon, May 18, 7:32 PM · Restricted Project
imaihal added a comment to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

Without this patch, following tests fail in SystemZ(z14)

MLIR :: mlir-cpu-runner/linalg_integration_test.mlir
MLIR :: mlir-cpu-runner/sgemm_naive_codegen.mlir
MLIR :: mlir-cpu-runner/simple.mlir
MLIR :: mlir-cpu-runner/unranked_memref.mlir
MLIR :: mlir-cpu-runner/utils.mlir

Error message is as follows.

Failure value returned from cantFail wrapped call
Added modules have incompatible data layouts: E-m:e-i1:8:16-i8:8:16-i64:64-f128:64-a:8:16-n32:64 (module) vs E-m:e-i1:8:16-i8:8:16-i64:6\
4-f128:64-v128:64-a:8:16-n32:64 (jit)
Mon, May 18, 9:07 AM · Restricted Project
imaihal created D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.
Mon, May 18, 9:07 AM · Restricted Project

Thu, Apr 30

imaihal added a comment to D78076: [mlir] Support big endian in DenseElementsAttr.

@rriddle Is this patch ready for commit? If so, could you help to commit this? I think I don't have write access to the repository.

Thu, Apr 30, 6:07 PM · Restricted Project
imaihal added a comment to D78076: [mlir] Support big endian in DenseElementsAttr.
In D78076#2012022, @ro wrote:

In short: create a complete patch that applies cleanly to current master and upload that. You should be fine then. At least my Solaris testing
after manually doing the same suggests so.

Thu, Apr 30, 5:11 PM · Restricted Project
imaihal updated the diff for D78076: [mlir] Support big endian in DenseElementsAttr.

Rebase

Thu, Apr 30, 9:02 AM · Restricted Project

Wed, Apr 29

imaihal added a comment to D78076: [mlir] Support big endian in DenseElementsAttr.

Pre-merge check fails, but I'm not sure why this happens. Could you tell me how to resolve this? (I'm new about Phabricator and archanist. Excuse me if this is basic question)

Wed, Apr 29, 6:24 PM · Restricted Project

Tue, Apr 28

imaihal added a comment to D78076: [mlir] Support big endian in DenseElementsAttr.

Is there any way you can add a test for this?

Tue, Apr 28, 9:38 AM · Restricted Project
imaihal added a comment to D78076: [mlir] Support big endian in DenseElementsAttr.
In D78076#1993928, @ro wrote:

FWIW, a rebased version of this patch (it needed llvm/Support/Endian.h, among others) fixed the vast majority of mlir failures I'd been
seeing on sparcv9-sun-solaris2.11.

Tue, Apr 28, 9:38 AM · Restricted Project
imaihal updated the diff for D78076: [mlir] Support big endian in DenseElementsAttr.

[mlir] Added copy_n() in static helper

Tue, Apr 28, 9:06 AM · Restricted Project

Apr 16 2020

imaihal added inline comments to D78076: [mlir] Support big endian in DenseElementsAttr.
Apr 16 2020, 4:43 PM · Restricted Project
imaihal updated the diff for D78076: [mlir] Support big endian in DenseElementsAttr.

[mlir] Create a static helper and add comments

Apr 16 2020, 7:49 AM · Restricted Project

Apr 13 2020

imaihal created D78076: [mlir] Support big endian in DenseElementsAttr.
Apr 13 2020, 8:14 PM · Restricted Project