Page MenuHomePhabricator

[IRSim][IROutliner] Canonicalizing commutative value numbering between similarity sections.
Needs ReviewPublic

Authored by AndrewLitteken on Fri, Jun 11, 12:05 PM.

Details

Reviewers
jroelofs
paquette
Summary

When the initial relationship between two pairs of values between similar sections is ambiguous to commutativity, arguments to the outlined functions can be passed in such that the order is incorrect, causing miscompilations. This adds a canonical mapping to each similarity section, so that we can maintain the relationship of global value numbering from one section to another.

Added Tests:
Transforms/IROutliner/outlining-commutative-operands-opposite-order.ll
unittests/Analysis/IRSimilarityIdentifierTest.cpp - IRSimilarityCandidate:CanonicalNumbering

Diff Detail

Event Timeline

AndrewLitteken requested review of this revision.Fri, Jun 11, 12:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jun 11, 12:05 PM
ormris removed a subscriber: ormris.Fri, Jun 11, 2:49 PM