- moves std::hash and std::unary_function into __functional
- Everything else goes into __utility/${NAME}.h
Details
- Reviewers
ldionne zoecarver Mordante • Quuxplusone - Group Reviewers
Restricted Project - Commits
- rG69d5a6662115: [libcxx][modularisation] splits `<utility>` into self-contained headers
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
Moving unary_function without also moving binary_function is unusual.
Anyway, please hold off on this until after D103753 is landed.
I suggest you carefully read the changes to learn why I didn't move binary_function out of <utility>. Seriously, I have a good reason.
I assume you're going to move binary_function out of __functional_base eventually, when we break up that header?
Did you make any changes to the code itself? Assuming you did not, this LGTM with the two indentation nitpicks fixed and the CI passing.
libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.fail.cpp | ||
---|---|---|
35 | Why this weird indentation change? Please leave as previously. | |
libcxx/test/std/utilities/utility/pairs/pair.astuple/tuple_element.fail.cpp | ||
20–22 | Same, please don't change indentation here. It's idiomatic to put the expected-error on the same line as the thing that triggers it. |
Yes. It would be strange to start splitting up __functional_base in a commit concerned with splitting <utility>.
Did you make any changes to the code itself? Assuming you did not, this LGTM with the two indentation nitpicks fixed and the CI passing.
No changes to the code.
Why this weird indentation change? Please leave as previously.