[llvm] Sync DebugInfo.h with DebugInfoFlags.def

[jankratochvil]

Summary

It is obviously correct but cannot such change have some stable API impact?
llvm/include/llvm/IR/DebugInfoFlags.def
Used a simple shell script to sync it.

[jankratochvil]

llvm/include/llvm-c/DebugInfo.h

45

forgotten in D66352

60

forgotten in D49887

[jankratochvil]

@jberdine I had to update the OCaml bindings as otherwise a buildbot failed.

/b/1/openmp-clang-x86_64-linux-debian/llvm.build/bindings/ocaml/debuginfo/debuginfo_ocaml.c: In function ‘map_DIFlag’:
/b/1/openmp-clang-x86_64-linux-debian/llvm.build/bindings/ocaml/debuginfo/debuginfo_ocaml.c:104:12: error: ‘LLVMDIFlagReserved’ undeclared (first use in this function); did you mean
‘i_DIFlagReserved’?
     return LLVMDIFlagReserved;
            ^~~~~~~~~~~~~~~~~~
            i_DIFlagReserved

I have fixed it based on a local build with OCaml (Fedora 34 x86_64). This is not a full OCaml sync with llvm/include/llvm/IR/DebugInfoFlags.def, just the part required to sync llvm/include/llvm-c/DebugInfo.h.
@jberdine Are you fine with this change?

[jberdine]

LGTM. No-one should be using enum tags named "Reserved" so I'm not worried about compatibility.

Is there a comment or something that would have pointed you to the debuginfo_ocaml.c change before the buildbots complained?

CC @vaivaswatha for info.

[jankratochvil]

llvm/include/llvm/IR/DebugInfoFlags.def

30

In D103910#2808022, @jberdine wrote:

Is there a comment or something that would have pointed you to the debuginfo_ocaml.c change before the buildbots complained?

Do you mean something like this?

[jberdine]

llvm/include/llvm/IR/DebugInfoFlags.def

30

Yes, that seems good. I don't know if others want the core sources "polluted" :-) by references to other language bindings though.

llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c

 |*                                                                            *|
 |* Note that these functions intentionally take liberties with the CAMLparamX *|
 |* macros, since most of the parameters are not GC heap objects.              *|
 |*                                                                            *|
 \*===----------------------------------------------------------------------===*/
 
 #include <string.h>
 
 #include "caml/memory.h"
 #include "caml/mlvalues.h"
 #include "llvm-c/Core.h"
 #include "llvm-c/DebugInfo.h"
 #include "llvm-c/Support.h"
 
 #include "llvm_ocaml.h"
 
 // This is identical to the definition in llvm_debuginfo.ml:DIFlag.t
typedef enum {
   i_DIFlagExplicit,
   i_DIFlagPrototyped,
   i_DIFlagObjcClassComplete,
   i_DIFlagObjectPointer,
   i_DIFlagVector,
   i_DIFlagStaticMember,
   i_DIFlagLValueReference,
   i_DIFlagRValueReference,
-  i_DIFlagReserved,
+  i_DIFlagExportSymbols,
   i_DIFlagSingleInheritance,
   i_DIFlagMultipleInheritance,
   i_DIFlagVirtualInheritance,
   i_DIFlagIntroducedVirtual,
   i_DIFlagBitField,
   i_DIFlagNoReturn,
   i_DIFlagTypePassByValue,
   i_DIFlagTypePassByReference,
static LLVMDIFlags map_DIFlag(LLVMDIFlag_i DIF) {
   case i_DIFlagVector:
     return LLVMDIFlagVector;
   case i_DIFlagStaticMember:
     return LLVMDIFlagStaticMember;
   case i_DIFlagLValueReference:
     return LLVMDIFlagLValueReference;
   case i_DIFlagRValueReference:
     return LLVMDIFlagRValueReference;
-  case i_DIFlagReserved:
-    return LLVMDIFlagReserved;
+  case i_DIFlagExportSymbols:
+    return LLVMDIFlagExportSymbols;
   case i_DIFlagSingleInheritance:
     return LLVMDIFlagSingleInheritance;
   case i_DIFlagMultipleInheritance:
     return LLVMDIFlagMultipleInheritance;
   case i_DIFlagVirtualInheritance:
     return LLVMDIFlagVirtualInheritance;
   case i_DIFlagIntroducedVirtual:
     return LLVMDIFlagIntroducedVirtual;

llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml

type t =
     | Explicit
     | Prototyped
     | ObjcClassComplete
     | ObjectPointer
     | Vector
     | StaticMember
     | LValueReference
     | RValueReference
-    | Reserved
+    | ExportSymbols
     | SingleInheritance
     | MultipleInheritance
     | VirtualInheritance
     | IntroducedVirtual
     | BitField
     | NoReturn
     | TypePassByValue
     | TypePassByReference

llvm/bindings/ocaml/debuginfo/llvm_debuginfo.mli

type t =
     | Explicit
     | Prototyped
     | ObjcClassComplete
     | ObjectPointer
     | Vector
     | StaticMember
     | LValueReference
     | RValueReference
-    | Reserved
+    | ExportSymbols
     | SingleInheritance
     | MultipleInheritance
     | VirtualInheritance
     | IntroducedVirtual
     | BitField
     | NoReturn
     | TypePassByValue
     | TypePassByReference

llvm/include/llvm-c/DebugInfo.h

typedef enum {
   LLVMDIFlagExplicit = 1 << 7,
   LLVMDIFlagPrototyped = 1 << 8,
   LLVMDIFlagObjcClassComplete = 1 << 9,
   LLVMDIFlagObjectPointer = 1 << 10,
   LLVMDIFlagVector = 1 << 11,
   LLVMDIFlagStaticMember = 1 << 12,
   LLVMDIFlagLValueReference = 1 << 13,
   LLVMDIFlagRValueReference = 1 << 14,
-  LLVMDIFlagReserved = 1 << 15,
+  LLVMDIFlagExportSymbols = 1 << 15,
   LLVMDIFlagSingleInheritance = 1 << 16,
   LLVMDIFlagMultipleInheritance = 2 << 16,
   LLVMDIFlagVirtualInheritance = 3 << 16,
   LLVMDIFlagIntroducedVirtual = 1 << 18,
   LLVMDIFlagBitField = 1 << 19,
   LLVMDIFlagNoReturn = 1 << 20,
   LLVMDIFlagTypePassByValue = 1 << 22,
   LLVMDIFlagTypePassByReference = 1 << 23,
   LLVMDIFlagEnumClass = 1 << 24,
   LLVMDIFlagFixedEnum = LLVMDIFlagEnumClass, // Deprecated.
   LLVMDIFlagThunk = 1 << 25,
   LLVMDIFlagNonTrivial = 1 << 26,
   LLVMDIFlagBigEndian = 1 << 27,
   LLVMDIFlagLittleEndian = 1 << 28,
+  LLVMDIFlagAllCallsDescribed = 1 << 29,
   LLVMDIFlagIndirectVirtualBase = (1 << 2) | (1 << 5),
   LLVMDIFlagAccessibility = LLVMDIFlagPrivate | LLVMDIFlagProtected |
                             LLVMDIFlagPublic,
   LLVMDIFlagPtrToMemberRep = LLVMDIFlagSingleInheritance |
                              LLVMDIFlagMultipleInheritance |
                              LLVMDIFlagVirtualInheritance
 } LLVMDIFlags;
 
 /**
  * Source languages known by DWARF.

llvm/include/llvm/IR/DebugInfoFlags.def

 #define HANDLE_DI_FLAG(ID, NAME)
 #endif
 
 #ifndef HANDLE_DISP_FLAG
 #define HANDLE_DISP_FLAG(ID, NAME)
 #endif
 
 // General flags kept in DINode.
+// Keep it in sync these files:
+//   llvm/include/llvm-c/DebugInfo.h
+//   llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c
+//   llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml
+//   llvm/bindings/ocaml/debuginfo/llvm_debuginfo.mli
 
 HANDLE_DI_FLAG(0, Zero) // Use it as zero value.
                         // For example: void foo(DIFlags Flags = FlagZero).
 HANDLE_DI_FLAG(1, Private)
 HANDLE_DI_FLAG(2, Protected)
 HANDLE_DI_FLAG(3, Public)
 HANDLE_DI_FLAG((1 << 2), FwdDecl)
 HANDLE_DI_FLAG((1 << 3), AppleBlock)