This is an archive of the discontinued LLVM Phabricator instance.

Differential D103910

[llvm] Sync DebugInfo.h with DebugInfoFlags.def
AcceptedPublic

Authored by jankratochvil on Jun 8 2021, 9:38 AM.

Details

Reviewers
aprantl
dblaikie
deadalnix
jberdine
Commits
rG093750dd0be6: [llvm] Sync DebugInfo.h with DebugInfoFlags.def
Summary

It is obviously correct but cannot such change have some stable API impact?
llvm/include/llvm/IR/DebugInfoFlags.def
Used a simple shell script to sync it.

Diff Detail

Event Timeline

jankratochvil created this revision.Jun 8 2021, 9:38 AM
Herald added a reviewer: deadalnix. · View Herald TranscriptJun 8 2021, 9:38 AM
jankratochvil requested review of this revision.Jun 8 2021, 9:38 AM
jankratochvil added inline comments.
llvm/include/llvm-c/DebugInfo.h
45

forgotten in D66352

60

forgotten in D49887

jankratochvil edited the summary of this revision. (Show Details)Jun 8 2021, 9:41 AM
jankratochvil added a child revision: D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.
Harbormaster completed remote builds in B108233: Diff 350630.Jun 8 2021, 9:55 AM
jankratochvil added a subscriber: jberdine.Jun 8 2021, 12:07 PM
aprantl accepted this revision.Jun 8 2021, 3:25 PM
This revision is now accepted and ready to land.Jun 8 2021, 3:25 PM
This revision was landed with ongoing or failed builds.Jun 9 2021, 1:13 AM
Closed by commit rG093750dd0be6: [llvm] Sync DebugInfo.h with DebugInfoFlags.def (authored by jankratochvil). · Explain Why
This revision was automatically updated to reflect the committed changes.
jankratochvil added a commit: rG093750dd0be6: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
jankratochvil added a reverting change: rG09ac4eca6650: Revert "[llvm] Sync DebugInfo.h with DebugInfoFlags.def".Jun 9 2021, 1:40 AM
jankratochvil edited the summary of this revision. (Show Details)Jun 9 2021, 7:00 AM
jankratochvil added a reviewer: jberdine.
jankratochvil removed a subscriber: jberdine.
jankratochvil updated this revision to Diff 350887.Jun 9 2021, 7:04 AM

@jberdine I had to update the OCaml bindings as otherwise a buildbot failed.

/b/1/openmp-clang-x86_64-linux-debian/llvm.build/bindings/ocaml/debuginfo/debuginfo_ocaml.c: In function ‘map_DIFlag’:
/b/1/openmp-clang-x86_64-linux-debian/llvm.build/bindings/ocaml/debuginfo/debuginfo_ocaml.c:104:12: error: ‘LLVMDIFlagReserved’ undeclared (first use in this function); did you mean
‘i_DIFlagReserved’?
     return LLVMDIFlagReserved;
            ^~~~~~~~~~~~~~~~~~
            i_DIFlagReserved

I have fixed it based on a local build with OCaml (Fedora 34 x86_64). This is not a full OCaml sync with llvm/include/llvm/IR/DebugInfoFlags.def, just the part required to sync llvm/include/llvm-c/DebugInfo.h.
@jberdine Are you fine with this change?

jankratochvil reopened this revision.Jun 9 2021, 7:04 AM
This revision is now accepted and ready to land.Jun 9 2021, 7:04 AM
jberdine accepted this revision.Jun 9 2021, 7:22 AM
jberdine added a subscriber: vaivaswatha.

LGTM. No-one should be using enum tags named "Reserved" so I'm not worried about compatibility.

Is there a comment or something that would have pointed you to the debuginfo_ocaml.c change before the buildbots complained?

CC @vaivaswatha for info.

jankratochvil updated this revision to Diff 350895.Jun 9 2021, 7:37 AM
Herald added a subscriber: dexonsmith. · View Herald TranscriptJun 9 2021, 7:37 AM
jankratochvil added inline comments.Jun 9 2021, 7:38 AM
llvm/include/llvm/IR/DebugInfoFlags.def
30 ↗(On Diff #350895)
In D103910#2808022, @jberdine wrote:

Is there a comment or something that would have pointed you to the debuginfo_ocaml.c change before the buildbots complained?

Do you mean something like this?

jberdine added inline comments.Jun 9 2021, 7:41 AM
llvm/include/llvm/IR/DebugInfoFlags.def
30 ↗(On Diff #350895)

Yes, that seems good. I don't know if others want the core sources "polluted" :-) by references to other language bindings though.

jankratochvil mentioned this in D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.Jun 9 2021, 8:02 AM
Harbormaster completed remote builds in B108414: Diff 350895.Jun 9 2021, 8:45 AM
jankratochvil mentioned this in D104014: [ocaml] [cmake] Fix make install error due to missing ocaml_doc.Jun 10 2021, 2:05 AM

Revision Contents

PathSize
llvm/
include/
llvm-c/
3 lines

Diff 350630

llvm/include/llvm-c/DebugInfo.h

Show All 36 Linestypedef enum {
LLVMDIFlagExplicit = 1 << 7, LLVMDIFlagExplicit = 1 << 7,
LLVMDIFlagPrototyped = 1 << 8, LLVMDIFlagPrototyped = 1 << 8,
LLVMDIFlagObjcClassComplete = 1 << 9, LLVMDIFlagObjcClassComplete = 1 << 9,
LLVMDIFlagObjectPointer = 1 << 10, LLVMDIFlagObjectPointer = 1 << 10,
LLVMDIFlagVector = 1 << 11, LLVMDIFlagVector = 1 << 11,
LLVMDIFlagStaticMember = 1 << 12, LLVMDIFlagStaticMember = 1 << 12,
LLVMDIFlagLValueReference = 1 << 13, LLVMDIFlagLValueReference = 1 << 13,
LLVMDIFlagRValueReference = 1 << 14, LLVMDIFlagRValueReference = 1 << 14,
LLVMDIFlagReserved = 1 << 15, LLVMDIFlagExportSymbols = 1 << 15,
jankratochvilAuthorUnsubmitted
Done
ReplyInline Actions

forgotten in D66352

jankratochvil: forgotten in D66352
LLVMDIFlagSingleInheritance = 1 << 16, LLVMDIFlagSingleInheritance = 1 << 16,
LLVMDIFlagMultipleInheritance = 2 << 16, LLVMDIFlagMultipleInheritance = 2 << 16,
LLVMDIFlagVirtualInheritance = 3 << 16, LLVMDIFlagVirtualInheritance = 3 << 16,
LLVMDIFlagIntroducedVirtual = 1 << 18, LLVMDIFlagIntroducedVirtual = 1 << 18,
LLVMDIFlagBitField = 1 << 19, LLVMDIFlagBitField = 1 << 19,
LLVMDIFlagNoReturn = 1 << 20, LLVMDIFlagNoReturn = 1 << 20,
LLVMDIFlagTypePassByValue = 1 << 22, LLVMDIFlagTypePassByValue = 1 << 22,
LLVMDIFlagTypePassByReference = 1 << 23, LLVMDIFlagTypePassByReference = 1 << 23,
LLVMDIFlagEnumClass = 1 << 24, LLVMDIFlagEnumClass = 1 << 24,
LLVMDIFlagFixedEnum = LLVMDIFlagEnumClass, // Deprecated. LLVMDIFlagFixedEnum = LLVMDIFlagEnumClass, // Deprecated.
LLVMDIFlagThunk = 1 << 25, LLVMDIFlagThunk = 1 << 25,
LLVMDIFlagNonTrivial = 1 << 26, LLVMDIFlagNonTrivial = 1 << 26,
LLVMDIFlagBigEndian = 1 << 27, LLVMDIFlagBigEndian = 1 << 27,
LLVMDIFlagLittleEndian = 1 << 28, LLVMDIFlagLittleEndian = 1 << 28,
LLVMDIFlagAllCallsDescribed = 1 << 29,
jankratochvilAuthorUnsubmitted
Done
ReplyInline Actions

forgotten in D49887

jankratochvil: forgotten in D49887
LLVMDIFlagIndirectVirtualBase = (1 << 2) | (1 << 5), LLVMDIFlagIndirectVirtualBase = (1 << 2) | (1 << 5),
LLVMDIFlagAccessibility = LLVMDIFlagPrivate | LLVMDIFlagProtected | LLVMDIFlagAccessibility = LLVMDIFlagPrivate | LLVMDIFlagProtected |
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  LLVMDIFlagAccessibility = LLVMDIFlagPrivate | LLVMDIFlagProtected |
-                            LLVMDIFlagPublic,
+  LLVMDIFlagAccessibility =
+      LLVMDIFlagPrivate | LLVMDIFlagProtected | LLVMDIFlagPublic,
Lint: Pre-merge checks: clang-format: please reformat the code ``` - LLVMDIFlagAccessibility = LLVMDIFlagPrivate |…
LLVMDIFlagPublic, LLVMDIFlagPublic,
LLVMDIFlagPtrToMemberRep = LLVMDIFlagSingleInheritance | LLVMDIFlagPtrToMemberRep = LLVMDIFlagSingleInheritance |
LLVMDIFlagMultipleInheritance | LLVMDIFlagMultipleInheritance |
LLVMDIFlagVirtualInheritance LLVMDIFlagVirtualInheritance
} LLVMDIFlags; } LLVMDIFlags;
/** /**
* Source languages known by DWARF. * Source languages known by DWARF.
▲ Show 20 Lines • Show All 1,296 Lines • Show Last 20 Lines