Page MenuHomePhabricator

[llvm] Sync DebugInfo.h with DebugInfoFlags.def
AcceptedPublic

Authored by jankratochvil on Jun 8 2021, 9:38 AM.

Details

Summary

It is obviously correct but cannot such change have some stable API impact?
llvm/include/llvm/IR/DebugInfoFlags.def
Used a simple shell script to sync it.

Diff Detail

Unit TestsFailed

TimeTest
37,140 msx64 debian > libFuzzer.libFuzzer::fork.test
Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/SimpleTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/fork.test.tmp-SimpleTest

Event Timeline

jankratochvil created this revision.Jun 8 2021, 9:38 AM
jankratochvil requested review of this revision.Jun 8 2021, 9:38 AM
jankratochvil added inline comments.
llvm/include/llvm-c/DebugInfo.h
45

forgotten in D66352

60

forgotten in D49887

aprantl accepted this revision.Jun 8 2021, 3:25 PM
This revision is now accepted and ready to land.Jun 8 2021, 3:25 PM
This revision was landed with ongoing or failed builds.Jun 9 2021, 1:13 AM
This revision was automatically updated to reflect the committed changes.
jankratochvil edited the summary of this revision. (Show Details)Jun 9 2021, 7:00 AM
jankratochvil added a reviewer: jberdine.
jankratochvil removed a subscriber: jberdine.

@jberdine I had to update the OCaml bindings as otherwise a buildbot failed.

/b/1/openmp-clang-x86_64-linux-debian/llvm.build/bindings/ocaml/debuginfo/debuginfo_ocaml.c: In function ‘map_DIFlag’:
/b/1/openmp-clang-x86_64-linux-debian/llvm.build/bindings/ocaml/debuginfo/debuginfo_ocaml.c:104:12: error: ‘LLVMDIFlagReserved’ undeclared (first use in this function); did you mean
‘i_DIFlagReserved’?
     return LLVMDIFlagReserved;
            ^~~~~~~~~~~~~~~~~~
            i_DIFlagReserved

I have fixed it based on a local build with OCaml (Fedora 34 x86_64). This is not a full OCaml sync with llvm/include/llvm/IR/DebugInfoFlags.def, just the part required to sync llvm/include/llvm-c/DebugInfo.h.
@jberdine Are you fine with this change?

jankratochvil reopened this revision.Jun 9 2021, 7:04 AM
This revision is now accepted and ready to land.Jun 9 2021, 7:04 AM
jberdine accepted this revision.Jun 9 2021, 7:22 AM
jberdine added a subscriber: vaivaswatha.

LGTM. No-one should be using enum tags named "Reserved" so I'm not worried about compatibility.

Is there a comment or something that would have pointed you to the debuginfo_ocaml.c change before the buildbots complained?

CC @vaivaswatha for info.

jankratochvil added inline comments.Jun 9 2021, 7:38 AM
llvm/include/llvm/IR/DebugInfoFlags.def
30

Is there a comment or something that would have pointed you to the debuginfo_ocaml.c change before the buildbots complained?

Do you mean something like this?

jberdine added inline comments.Jun 9 2021, 7:41 AM
llvm/include/llvm/IR/DebugInfoFlags.def
30

Yes, that seems good. I don't know if others want the core sources "polluted" :-) by references to other language bindings though.