This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][Libomptarget] Remove atlc global
ClosedPublic

Authored by pdhaliwal on Jun 7 2021, 2:43 AM.

Details

Summary

This global struct used to hold various flags for monitoring the
initialization of hsa.

Diff Detail

Event Timeline

pdhaliwal created this revision.Jun 7 2021, 2:43 AM
pdhaliwal requested review of this revision.Jun 7 2021, 2:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2021, 2:43 AM
JonChesterfield accepted this revision.Jun 7 2021, 3:48 AM

Nice, thanks. The task support was nominally deleted some time ago, iirc the init() part survived because the variable was used elsewhere as well. Good to see it go.

openmp/libomptarget/plugins/amdgpu/impl/system.cpp
144

Is the type atl_context_t now unused too?

458

This may mean parts of g_atl_machine can be deleted too

This revision is now accepted and ready to land.Jun 7 2021, 3:48 AM
pdhaliwal updated this revision to Diff 350237.Jun 7 2021, 4:07 AM

Remove atl_context_t struct

openmp/libomptarget/plugins/amdgpu/impl/system.cpp
144

Yes, it is unused. Will also include deletion of that in this patch.

This revision was landed with ongoing or failed builds.Jun 7 2021, 4:09 AM
This revision was automatically updated to reflect the committed changes.