Page MenuHomePhabricator

[AMDGPU] Stop using LegacyLegalizerInfo. NFCI.
ClosedPublic

Authored by foad on Jun 4 2021, 4:26 AM.

Diff Detail

Event Timeline

foad created this revision.Jun 4 2021, 4:26 AM
foad requested review of this revision.Jun 4 2021, 4:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2021, 4:26 AM
dsanders accepted this revision.Jun 4 2021, 10:52 AM

LGTM, Thanks!

llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
505

I'm not 100% sure off-hand if this one had any implicit clampScalar-like rules in the legacy info. I can believe that G_BRCOND only ever forms with s1/s32 though.

This revision is now accepted and ready to land.Jun 4 2021, 10:52 AM
foad added inline comments.Jun 7 2021, 1:48 AM
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
505

I admit that I don't know anything about implicit clamping in the legacy legalizer. But at least this patch passed all our tests.

This revision was automatically updated to reflect the committed changes.