[zorg] Add AArch64 SVE vector-length-specific (VLS) bot

[maxim-kuvyrkov]

Summary

At the moment the only SVE-enabled part is building/running testsuite,
and we'll enable 2-stage builds with SVE later.

[maxim-kuvyrkov]

Add 2-stage bot as well. These are running as expected at
http://ex40-01.tcwglab.linaro.org:8013/#/workers .

[rovka]

Seems ok, I just have one minor nit.

buildbot/osuosl/master/config/builders.py

508

Do we need testStage1 if test=True?

[DavidSpickett]

buildbot/osuosl/master/config/builders.py

513

Maybe a silly question, but why don't we also pass -mllvm -aarch64-sve-vector-bits-min=512 to this one?

Would it not make any difference?

[zatrazz]

buildbot/osuosl/master/config/builders.py

511

Wouldn't -march=armv8-a+​sve be more generic or are we trying to mimic what users currenctly might use?

[maxim-kuvyrkov]

buildbot/osuosl/master/config/builders.py

508

Good catch, this is a left-over from me testing 2-stage bot.

511

Setting "-aarch64-sve-vector-bits-min=512" is implementation-specific to A64FX, and using -mcpu=a64fx makes it a bit more explicit.

513

This is a very good question.

Extra_cmake_args are passed to both system compiler (while building stage1 clang) and to stage1 compiler (while building stage2 clang). Current system compiler on Linaro bots is Clang 12, which crashes on several LLVM sources with "-mllvm -aarch64-sve-vector-bits-min=512".

Given that "-mllvm foo" options are not intended to normal users, it's better, imo, to just not torture system compiler with it needlessly.

Now, if Clang 12 crashes with "-mllvm -aarch64-sve-vector-bits-min=512" in extra_cmake_flags, how does below *-sve-vls-stage2 bot works? For that bot we have a workaround in our setup to filter out "-mllvm -aarch64-sve-vector-bits-min=512" options from the command line of the system compiler.

A better fix would be to enable separate stage1 and stage2 extra_cmake_flags. But, assuming that LLVM 13 will fix the SVE crashes, these per-stage flags will end up unused.

[DavidSpickett]

buildbot/osuosl/master/config/builders.py

513

Got it. That makes sense now.

[Matt]

buildbot/osuosl/master/config/builders.py

513

FWIW, LLVM has just gotten the new version of -msve-vector-bits=N (which also results in VLS codegen as an effect), https://reviews.llvm.org/D103702

buildbot/osuosl/master/config/builders.py

'factory' : ClangBuilder.getClangCMakeBuildFactory(
                     runTestSuite=True,
                     testsuite_flags=[
                         '--cppflags', '-mcpu=cortex-a57',
                         '--threads=32', '--build-threads=32'],
                     extra_cmake_args=[
                         "-DCMAKE_C_FLAGS='-mcpu=cortex-a57'",
                         "-DCMAKE_CXX_FLAGS='-mcpu=cortex-a57'"])},
 
+    # AArch64 Clang+LLVM+RT+LLD check-all + flang + test-suite w/SVE
+    {'name' : "clang-cmake-aarch64-sve-vls",
+    'tags'  : ["clang"],
+    'workernames' : ["linaro-aarch64-sve-vls"],
+    'builddir': "clang-cmake-aarch64-sve-vls",
+    'factory' : ClangBuilder.getClangCMakeBuildFactory(
+                    clean=False,
+                    checkout_compiler_rt=True,
+                    checkout_flang=True,
+                    checkout_lld=True,
+                    test=True,
+                    useTwoStage=False,
+                    testStage1=True,
+                    runTestSuite=True,
+                    testsuite_flags=[
+                        '--cppflags', '-mcpu=a64fx -mllvm -aarch64-sve-vector-bits-min=512',
+                        '--threads=48', '--build-threads=48'],
+                    extra_cmake_args=[
+                        "-DCMAKE_C_FLAGS='-mcpu=a64fx'",
+                        "-DCMAKE_CXX_FLAGS='-mcpu=a64fx'",
+                        "-DLLVM_ENABLE_LLD=True"])},
+
+    # AArch64 Clang+LLVM+RT+LLD check-all + flang + test-suite 2-stage w/SVE
+    {'name' : "clang-cmake-aarch64-sve-vls-2stage",
+    'tags'  : ["clang"],
+    'workernames' : ["linaro-aarch64-sve-vls-2stage"],
+    'builddir': "clang-cmake-aarch64-sve-vls-2stage",
+    'factory' : ClangBuilder.getClangCMakeBuildFactory(
+                    clean=False,
+                    checkout_compiler_rt=True,
+                    checkout_flang=True,
+                    checkout_lld=True,
+                    test=True,
+                    useTwoStage=True,
+                    testStage1=False,
+                    runTestSuite=True,
+                    testsuite_flags=[
+                        '--cppflags', '-mcpu=a64fx -mllvm -aarch64-sve-vector-bits-min=512',
+                        '--threads=48', '--build-threads=48'],
+                    extra_cmake_args=[
+                        "-DCMAKE_C_FLAGS='-mcpu=a64fx -mllvm -aarch64-sve-vector-bits-min=512'",
+                        "-DCMAKE_CXX_FLAGS='-mcpu=a64fx -mllvm -aarch64-sve-vector-bits-min=512'",
+                        "-DLLVM_ENABLE_LLD=True"])},
+
     {'name' : "clang-arm64-windows-msvc-2stage",
     'tags'  : ["clang"],
     'workernames' : ["linaro-armv8-windows-msvc-01", "linaro-armv8-windows-msvc-02"],
     'builddir': "clang-arm64-windows-msvc-2stage",
     'factory' : ClangBuilder.getClangCMakeBuildFactory(
                     vs="manual",
                     test=False, # Disable testing until MCJIT failures are fixed
                     useTwoStage=True,

buildbot/osuosl/master/config/workers.py

return [
         create_worker("linaro-armv8-libcxx", properties={'jobs' : 1}, max_builds=1),
         create_worker("linaro-arm-lldb", properties={'jobs' : 16}, max_builds=1),
 
         # AArch64 Linaro workers
         create_worker("linaro-aarch64-quick", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-full", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-global-isel", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-lld", properties={'jobs' : 32}, max_builds=1),
+        create_worker("linaro-aarch64-sve-vls", properties={'jobs' : 48}, max_builds=1),
+        create_worker("linaro-aarch64-sve-vls-2stage", properties={'jobs' : 48}, max_builds=1),
         create_worker("linaro-aarch64-flang-oot", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-flang-debug", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-flang-latest-clang", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-flang-release", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-flang-rel-assert", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-flang-dylib", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-flang-sharedlibs", properties={'jobs' : 32}, max_builds=1),
         create_worker("linaro-aarch64-flang-latest-gcc", properties={'jobs' : 32}, max_builds=1),