- Group Reviewers
- rG05d164b25c40: Revert "[libc++] NFC: Move unwrap_iter to its own header"
rG924ea3bb53ca: [libc++] NFC: Move unwrap_iter to its own header
Well, my solution was to add this new header (and all new headers) to module.modulemap. So I assume this PR will fail buildkite as-is; it would need to add this header (and/or other new headers) to module.modulemap in order to keep buildkite happy. But I recommend people discuss the issue/solution(s) over on https://reviews.llvm.org/D102781#inline-979125 just to keep it all in the same place.
I agree it would be good to keep the discussion in D102781. This is mainly to test whether your approach also works here or more changes are required. The original patch broke the Linux builds. I tested Linux locally with only your __iterator_iterator_traits_h module applied and that fixed it locally.
Poke CI. I suspect the previous failure is a fluke because it only happens in the back-deployment configuration, and those nodes were problematic in the past few days. Will investigate if it fails again.