Page MenuHomePhabricator

[RISCV] Remove -riscv-no-aliases in favour of new -M no-aliases
AcceptedPublic

Authored by jrtc27 on May 26 2021, 1:08 PM.

Diff Detail

Event Timeline

jrtc27 created this revision.May 26 2021, 1:08 PM
jrtc27 requested review of this revision.May 26 2021, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 1:08 PM
MaskRay accepted this revision.May 26 2021, 1:20 PM

You can delete -o - for llvm-mc while updating the tests.

llvm/test/MC/RISCV/rv32fc-valid.s
10

Reflow as # RUN: not llvm-mc -triple riscv32 \ is now too short.

This revision is now accepted and ready to land.May 26 2021, 1:20 PM
jrtc27 added inline comments.May 26 2021, 1:24 PM
llvm/test/MC/RISCV/rv32fc-valid.s
10

Blegh, probably a load of similar cases in d63d662d3cc51219fb08908ebea8d5851e53adb8 :(

You can delete -o - for llvm-mc while updating the tests.

I'd have to also change it to < %s for those two RUN lines, though, right?

llvm-mc %s prints to stdout. You can omit <.

This revision was landed with ongoing or failed builds.May 29 2021, 6:59 AM
This revision was automatically updated to reflect the committed changes.
jrtc27 reopened this revision.May 29 2021, 7:13 AM

This needs more work to wire up -M for llc :( I thought I had tested this...

This revision is now accepted and ready to land.May 29 2021, 7:13 AM