This a minor patch to refactor the test file, llvm-objdump/XCOFF/section-headers.test, to use yaml2obj for this testing rather than a canned binary.
jhenderson shchenz Higuoxing MaskRay
- Group Reviewers
- rGdb4ac5a63e11: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of…
Nit: here and elsewhere, remove the excessive spacing, as per the inline example.
I know this was there before, but is this the full error message? I'd expect it to at least say something like: "error: ...". Also, a separate patch, but this error does not follow the LLVM style guide for error messages (it should be "the end", not "The end").
https://reviews.llvm.org/harbormaster/unit/view/775092/ suggests there might be a problem here. This will expand to a Windows path with only single backslashes in which will cause problems when python tries to consume it on some machines (because \<char> might be an escape char). I think there's a simple fix: use %/t instead, as that replaces all backslashes with forward slashes in the substitution.