This is an archive of the discontinued LLVM Phabricator instance.

Differential D102997

[MLIR] Drop old cmake var names
ClosedPublic

Authored by bondhugula on May 23 2021, 8:23 PM.

Details

Reviewers
stellaraccident
mehdi_amini
Commits
rG587408c199e8: [MLIR] Drop old cmake var names
Summary

Drop old cmake variable names that were kept around so that zorg
buildbot could be migrated, which has now happened (D102977). D102976
had fixed the inconsistent names.

Diff Detail

Event Timeline

bondhugula created this revision.May 23 2021, 8:23 PM
Herald added subscribers: dcaballe, cota, teijeong and 17 others. · View Herald TranscriptMay 23 2021, 8:23 PM
bondhugula requested review of this revision.May 23 2021, 8:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2021, 8:23 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
bondhugula updated this revision to Diff 347298.May 23 2021, 8:29 PM
bondhugula retitled this revision from [MLIR] Drop old cmake var namees to [MLIR] Drop old cmake var names.

Fix typo in commit title.

stellaraccident accepted this revision.May 23 2021, 8:39 PM

Marking as accepted for when the running is right to land.

This revision is now accepted and ready to land.May 23 2021, 8:39 PM
Harbormaster completed remote builds in B105838: Diff 347298.May 23 2021, 9:02 PM
Closed by commit rG587408c199e8: [MLIR] Drop old cmake var names (authored by bondhugula). · Explain WhyMay 24 2021, 3:01 AM
This revision was automatically updated to reflect the committed changes.
bondhugula added a commit: rG587408c199e8: [MLIR] Drop old cmake var names.

Revision Contents

PathSize
mlir/
18 lines

Diff 347298

mlir/CMakeLists.txt

Show First 20 Lines • Show All 66 Lines • ▼ Show 20 Lines
# is available # is available
if ("AMDGPU" IN_LIST LLVM_TARGETS_TO_BUILD) if ("AMDGPU" IN_LIST LLVM_TARGETS_TO_BUILD)
set(MLIR_ENABLE_ROCM_CONVERSIONS 1) set(MLIR_ENABLE_ROCM_CONVERSIONS 1)
else() else()
set(MLIR_ENABLE_ROCM_CONVERSIONS 0) set(MLIR_ENABLE_ROCM_CONVERSIONS 0)
endif() endif()
add_definitions(-DMLIR_ROCM_CONVERSIONS_ENABLED=${MLIR_ENABLE_ROCM_CONVERSIONS}) add_definitions(-DMLIR_ROCM_CONVERSIONS_ENABLED=${MLIR_ENABLE_ROCM_CONVERSIONS})
# Until the buildbot configuration is updated, preserve old names. set(MLIR_ENABLE_CUDA_RUNNER 0 CACHE BOOL "Enable building the mlir CUDA runner")
if (${MLIR_CUDA_RUNNER_ENABLED})
set(MLIR_ENABLE_CUDA_RUNNER_DEFAULT ${MLIR_CUDA_RUNNER_ENABLED})
else()
set(MLIR_ENABLE_CUDA_RUNNER_DEFAULT 0)
endif()
set(MLIR_ENABLE_CUDA_RUNNER ${MLIR_ENABLE_CUDA_RUNNER_DEFAULT} CACHE BOOL "Enable building the mlir CUDA runner")
set(MLIR_ENABLE_ROCM_RUNNER 0 CACHE BOOL "Enable building the mlir ROCm runner") set(MLIR_ENABLE_ROCM_RUNNER 0 CACHE BOOL "Enable building the mlir ROCm runner")
set(MLIR_ENABLE_SPIRV_CPU_RUNNER 0 CACHE BOOL "Enable building the mlir SPIR-V cpu runner") set(MLIR_ENABLE_SPIRV_CPU_RUNNER 0 CACHE BOOL "Enable building the mlir SPIR-V cpu runner")
set(MLIR_ENABLE_VULKAN_RUNNER 0 CACHE BOOL "Enable building the mlir Vulkan runner") set(MLIR_ENABLE_VULKAN_RUNNER 0 CACHE BOOL "Enable building the mlir Vulkan runner")
option(MLIR_INCLUDE_TESTS option(MLIR_INCLUDE_TESTS
"Generate build targets for the MLIR unit tests." "Generate build targets for the MLIR unit tests."
${LLVM_INCLUDE_TESTS}) ${LLVM_INCLUDE_TESTS})
Show All 10 Lines
# --------------- # ---------------
# By default, python extensions are version locked to specific Python libraries. # By default, python extensions are version locked to specific Python libraries.
# This linking mode is somewhat more consistent across platforms and surfaces # This linking mode is somewhat more consistent across platforms and surfaces
# undefined symbols at link time (vs runtime). It is suitable for development # undefined symbols at link time (vs runtime). It is suitable for development
# workflows but can be disabled for more flexible deployment by # workflows but can be disabled for more flexible deployment by
# setting -DMLIR_BINDINGS_PYTHON_LOCK_VERSION=OFF # setting -DMLIR_BINDINGS_PYTHON_LOCK_VERSION=OFF
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# Until the buildbot configuration is updated, support old name. set(MLIR_ENABLE_BINDINGS_PYTHON 0 CACHE BOOL
if (${MLIR_BINDINGS_PYTHON_ENABLED})
set(MLIR_ENABLE_BINDINGS_PYTHON_DEFAULT ${MLIR_BINDINGS_PYTHON_ENABLED})
else()
set(MLIR_ENABLE_BINDINGS_PYTHON_DEFAULT 0)
endif()
set(MLIR_ENABLE_BINDINGS_PYTHON ${MLIR_ENABLE_BINDINGS_PYTHON_DEFAULT} CACHE BOOL
"Enables building of Python bindings.") "Enables building of Python bindings.")
set(MLIR_BINDINGS_PYTHON_LOCK_VERSION 1 CACHE BOOL set(MLIR_BINDINGS_PYTHON_LOCK_VERSION 1 CACHE BOOL
"Links to specific python libraries, resolving all symbols.") "Links to specific python libraries, resolving all symbols.")
if(MLIR_ENABLE_BINDINGS_PYTHON) if(MLIR_ENABLE_BINDINGS_PYTHON)
include(MLIRDetectPythonEnv) include(MLIRDetectPythonEnv)
find_package(Python3 ${LLVM_MINIMUM_PYTHON_VERSION} find_package(Python3 ${LLVM_MINIMUM_PYTHON_VERSION}
COMPONENTS Interpreter Development NumPy REQUIRED) COMPONENTS Interpreter Development NumPy REQUIRED)
▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines