This is an archive of the discontinued LLVM Phabricator instance.

Differential D102823

[llvm-objcopy] Update LIT test to resolve bot failure [NFC]
ClosedPublic

Authored by sdmitriev on May 19 2021, 7:51 PM.

Details

Reviewers
hubert.reinterpretcast
jhenderson
alexander-shaposhnikov
rupprecht
Commits
rG0b12963b747c: [llvm-objcopy] Update LIT test to resolve bot failure [NFC]

Diff Detail

Event Timeline

sdmitriev created this revision.May 19 2021, 7:51 PM
Herald added a reviewer: alexander-shaposhnikov. · View Herald TranscriptMay 19 2021, 7:51 PM
Herald added a reviewer: rupprecht. · View Herald Transcript
Herald added a subscriber: abrachet. · View Herald Transcript
sdmitriev requested review of this revision.May 19 2021, 7:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2021, 7:51 PM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
hubert.reinterpretcast accepted this revision.May 19 2021, 7:52 PM

LGTM; thanks!

This revision is now accepted and ready to land.May 19 2021, 7:52 PM
This revision was landed with ongoing or failed builds.May 19 2021, 8:21 PM
Closed by commit rG0b12963b747c: [llvm-objcopy] Update LIT test to resolve bot failure [NFC] (authored by sdmitriev). · Explain Why
This revision was automatically updated to reflect the committed changes.
sdmitriev added a commit: rG0b12963b747c: [llvm-objcopy] Update LIT test to resolve bot failure [NFC].
Harbormaster completed remote builds in B105346: Diff 346620.May 19 2021, 8:31 PM

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
4 lines

Diff 346623

llvm/test/tools/llvm-objcopy/dash-dash.test

## Create a clean temporary directory and cd to it to use relative paths. ## Create a clean temporary directory and cd to it to use relative paths.
# RUN: rm -rf %t && mkdir %t && cd %t # RUN: rm -rf %t && mkdir %t && cd %t
## Check that llvm-objcopy correctly treats paths after '--' as file paths, ## Check that llvm-objcopy correctly treats paths after '--' as file paths,
## even if they start with dashes. ## even if they start with dashes.
# RUN: yaml2obj %s -o test-obj # RUN: yaml2obj %s -o test-obj
# RUN: llvm-objcopy --only-section=.test test-obj -- --only-section # RUN: llvm-objcopy --only-section=.test test-obj -- --only-section
# RUN: llvm-objcopy --only-section=.test test-obj out-obj1 # RUN: llvm-objcopy --only-section=.test test-obj out-obj1
# RUN: cmp out-obj1 -- --only-section # RUN: cmp -- out-obj1 --only-section
## Check the case when '--' is specified with input files but no options. ## Check the case when '--' is specified with input files but no options.
# RUN: llvm-objcopy -- test-obj --add-section # RUN: llvm-objcopy -- test-obj --add-section
# RUN: llvm-objcopy test-obj out-obj2 # RUN: llvm-objcopy test-obj out-obj2
# RUN: cmp out-obj2 -- --add-section # RUN: cmp -- out-obj2 --add-section
## Check the case when '--' is specified with options but no input files. ## Check the case when '--' is specified with options but no input files.
# RUN: not llvm-objcopy --only-section=.test -- 2>&1 | FileCheck %s --check-prefixes=CHECK-NO-INPUT # RUN: not llvm-objcopy --only-section=.test -- 2>&1 | FileCheck %s --check-prefixes=CHECK-NO-INPUT
# CHECK-NO-INPUT: error: no input file specified # CHECK-NO-INPUT: error: no input file specified
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_REL Type: ET_REL