This is an archive of the discontinued LLVM Phabricator instance.

[SDAG] propagate FMF from target-specific IR intrinsics
ClosedPublic

Authored by spatel on May 18 2021, 2:05 PM.

Details

Summary

This is a step towards relying more on node-level FMF rather than function-wide or target settings. I think it was just an oversight that we didn't get this path in D87361 or follow-on patches.

The lack of FMF propagation is blocking D90901 from converting tests to IR-level FMF.

We can't do much more than this currently because we also fail to propagate flags from x86-specific node to generic FMA node. That would be another patch, so the test just verifies that we can transfer from IR to initial SDAG node.

Diff Detail

Event Timeline

spatel created this revision.May 18 2021, 2:05 PM
spatel requested review of this revision.May 18 2021, 2:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2021, 2:05 PM
qiucf accepted this revision.May 18 2021, 7:16 PM

LGTM, thanks.

This revision is now accepted and ready to land.May 18 2021, 7:16 PM
This revision was landed with ongoing or failed builds.May 19 2021, 4:52 AM
This revision was automatically updated to reflect the committed changes.