This is an archive of the discontinued LLVM Phabricator instance.

Differential D102578

[Demangle][Rust] Parse slice type
ClosedPublic

Authored by tmiasko on May 16 2021, 6:59 AM.

Details

Reviewers
dblaikie
Commits
rGa84c65c204cc: [Demangle][Rust] Parse slice type
Summary

Depends on D102573

Diff Detail

Event Timeline

tmiasko created this revision.May 16 2021, 6:59 AM
Herald added subscribers: JDevlieghere, hiraditya. · View Herald TranscriptMay 16 2021, 6:59 AM
tmiasko requested review of this revision.May 16 2021, 6:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2021, 6:59 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
tmiasko added a child revision: D102579: [Demangle][Rust] Parse tuples.May 16 2021, 7:03 AM
Harbormaster completed remote builds in B104707: Diff 345706.May 16 2021, 7:48 AM
dblaikie accepted this revision.May 16 2021, 10:22 AM

Looks good

This revision is now accepted and ready to land.May 16 2021, 10:22 AM
tmiasko updated this revision to Diff 345883.May 17 2021, 7:54 AM

Rebase

Harbormaster completed remote builds in B104831: Diff 345883.May 17 2021, 9:00 AM
Closed by commit rGa84c65c204cc: [Demangle][Rust] Parse slice type (authored by tmiasko). · Explain WhyMay 18 2021, 3:12 PM
This revision was automatically updated to reflect the committed changes.
tmiasko added a commit: rGa84c65c204cc: [Demangle][Rust] Parse slice type.
tmiasko mentioned this in D99981: [demangler] Support the new Rust mangling scheme (v0).Jun 23 2021, 3:07 PM

Revision Contents

PathSize
llvm/
lib/
Demangle/
5 lines
test/
Demangle/
3 lines

Diff 346283

llvm/lib/Demangle/RustDemangle.cpp

Show First 20 Lines • Show All 430 Lines • ▼ Show 20 Linesvoid Demangler::demangleType() {
switch (C) { switch (C) {
case 'A': case 'A':
print("["); print("[");
demangleType(); demangleType();
print("; "); print("; ");
demangleConst(); demangleConst();
print("]"); print("]");
break; break;
case 'S':
print("[");
demangleType();
print("]");
break;
default: default:
Position = Start; Position = Start;
demanglePath(InType::Yes); demanglePath(InType::Yes);
break; break;
} }
} }
// <const> = <basic-type> <const-data> // <const> = <basic-type> <const-data>
▲ Show 20 Lines • Show All 264 Lines • Show Last 20 Lines

llvm/test/Demangle/rust.test

Show First 20 Lines • Show All 154 Lines • ▼ Show 20 Lines
CHECK: named::<Name<>> CHECK: named::<Name<>>
_RIC5namedIC4NameEE _RIC5namedIC4NameEE
; Types ; Types
CHECK: types::<[u8; 0]> CHECK: types::<[u8; 0]>
_RIC5typesAhj0_E _RIC5typesAhj0_E
CHECK: types::<[_]>
_RIC5typesSpE
; Integer constants. Test value demangling. ; Integer constants. Test value demangling.
CHECK: integer::<0> CHECK: integer::<0>
_RIC7integerKi0_E _RIC7integerKi0_E
CHECK: integer::<1> CHECK: integer::<1>
_RIC7integerKi1_E _RIC7integerKi1_E
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines