Page MenuHomePhabricator

tmiasko (Tomasz Miąsko)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2021, 10:11 AM (85 w, 6 d)

Recent Activity

May 13 2022

tmiasko accepted D122604: [demangler] Simplify OutputBuffer initialization.

Looks good.

May 13 2022, 8:49 AM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2022

tmiasko accepted D123420: [demangler] Rust demangler buffer reuse.

LGTM. Thanks!

Apr 13 2022, 5:00 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

tmiasko added a comment to D123420: [demangler] Rust demangler buffer reuse.

The API thus far was intended to match that of __cxa_demangle, where the caller retains the ownership of the provided buffer when demangling fails. This is no longer the case in the new implementation. I would rather avoid diverging from __cxa_demangle in such a subtle way.

Ah, it took me a while to figure out where that's happening, I see it now. Awkward. I suppose the rust demangler could always return the new buffer (and free any incoming buffer) in the success case? Something like if (Buf) std::free(Buf); instead of that memcpy/free dance?

Apr 11 2022, 8:35 AM · Restricted Project, Restricted Project, Restricted Project

Apr 8 2022

tmiasko added a comment to D123420: [demangler] Rust demangler buffer reuse.

The API thus far was intended to match that of __cxa_demangle, where the caller retains the ownership of the provided buffer when demangling fails. This is no longer the case in the new implementation. I would rather avoid diverging from __cxa_demangle in such a subtle way.

Apr 8 2022, 5:02 PM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2021

tmiasko added a comment to D113750: [docs] Mention Rust v0 demangling support in release notes.

Part of Rust demangling changes landed back in LLVM 13, including demangling
support in lldb, llvm-cxxfilt, and llvm-objdump. At that time, they weren't
included in the release notes. Is there a practice of updating the release
notes for past releases, or maybe include them here as well?

Nov 12 2021, 3:57 AM · Restricted Project
tmiasko requested review of D113750: [docs] Mention Rust v0 demangling support in release notes.
Nov 12 2021, 3:54 AM · Restricted Project
tmiasko committed rGc3e07df60760: [llvm-nm] Demangle Rust symbols (authored by tmiasko).
[llvm-nm] Demangle Rust symbols
Nov 12 2021, 3:53 AM
tmiasko closed D111937: [llvm-nm] Demangle Rust symbols.
Nov 12 2021, 3:53 AM · Restricted Project

Oct 16 2021

tmiasko closed D110664: [Symbolize] Demangle Rust symbols.

Thanks for the review.

Oct 16 2021, 5:27 AM · Restricted Project
tmiasko requested review of D111937: [llvm-nm] Demangle Rust symbols.
Oct 16 2021, 5:16 AM · Restricted Project
tmiasko committed rG48ce523a26b7: [Symbolize] Demangle Rust symbols (authored by tmiasko).
[Symbolize] Demangle Rust symbols
Oct 16 2021, 4:35 AM
tmiasko committed rG41a6fc8438f3: [Demangle] Extract nonMicrosoftDemangle from llvm::demangle (authored by tmiasko).
[Demangle] Extract nonMicrosoftDemangle from llvm::demangle
Oct 16 2021, 4:35 AM
tmiasko committed rGa3813438ae1c: [llvm-cxxfilt] Use nonMicrosoftDemangle for demangling NFC (authored by tmiasko).
[llvm-cxxfilt] Use nonMicrosoftDemangle for demangling NFC
Oct 16 2021, 4:35 AM

Oct 12 2021

tmiasko added a comment to D110664: [Symbolize] Demangle Rust symbols.

Why the functional change to allow double underscore Rust symbols?

Oct 12 2021, 1:33 AM · Restricted Project
tmiasko added inline comments to D110664: [Symbolize] Demangle Rust symbols.
Oct 12 2021, 1:08 AM · Restricted Project
tmiasko updated the diff for D110664: [Symbolize] Demangle Rust symbols.

Remove unnecessary qualifiers

Oct 12 2021, 1:08 AM · Restricted Project

Oct 11 2021

tmiasko added inline comments to D110664: [Symbolize] Demangle Rust symbols.
Oct 11 2021, 2:39 PM · Restricted Project
tmiasko updated the diff for D110664: [Symbolize] Demangle Rust symbols.

Extract and reuse common demangling functionality.

Oct 11 2021, 2:37 PM · Restricted Project

Oct 1 2021

tmiasko committed rGf33274c7bf44: [llvm-cxxfilt] Replace isalnum with isAlnum from StringExtras (authored by tmiasko).
[llvm-cxxfilt] Replace isalnum with isAlnum from StringExtras
Oct 1 2021, 11:58 PM
tmiasko closed D110986: [llvm-cxxfilt] Replace isalnum with isAlnum from StringExtras.
Oct 1 2021, 11:57 PM · Restricted Project
tmiasko requested review of D110986: [llvm-cxxfilt] Replace isalnum with isAlnum from StringExtras.
Oct 1 2021, 11:01 PM · Restricted Project
tmiasko committed rGc8c2b4629f75: [Demangle][Rust] Parse non-ASCII identifiers (authored by tmiasko).
[Demangle][Rust] Parse non-ASCII identifiers
Oct 1 2021, 1:14 PM
tmiasko closed D104366: [Demangle][Rust] Parse non-ASCII identifiers.
Oct 1 2021, 1:14 PM · Restricted Project, Restricted Project
tmiasko added a comment to D104366: [Demangle][Rust] Parse non-ASCII identifiers.

Yeah, I'm fairly comfortable approving a change like this - but now that you mention the libc++abi surface area here: Are other features of Utility.h tested (unit tested?) somewhere? Could you add testing for this new function too?

Also, admittedly I don't fully understand how this LLVM change ended up needing a change to libc++abi - how do these pieces connect/depend on each other?

Oct 1 2021, 12:51 PM · Restricted Project, Restricted Project
tmiasko updated the diff for D104366: [Demangle][Rust] Parse non-ASCII identifiers.

Rebase and add a unit test for OutputStream::insert

Oct 1 2021, 12:37 PM · Restricted Project, Restricted Project
tmiasko added a comment to D104366: [Demangle][Rust] Parse non-ASCII identifiers.

Oh, I forgot this didn't land yet and didn't follow up. I wasn't exactly sure how to interpret blocking review by libc++abi. @dblaikie is your review sufficient for landing this? If not, @ldionne could you take a look at the small part of changes in libcxxabi?

Oct 1 2021, 2:05 AM · Restricted Project, Restricted Project
tmiasko added inline comments to D110664: [Symbolize] Demangle Rust symbols.
Oct 1 2021, 1:52 AM · Restricted Project

Sep 29 2021

tmiasko added inline comments to D110664: [Symbolize] Demangle Rust symbols.
Sep 29 2021, 3:27 AM · Restricted Project

Sep 28 2021

tmiasko added a reviewer for D110664: [Symbolize] Demangle Rust symbols: dblaikie.
Sep 28 2021, 3:36 PM · Restricted Project
tmiasko requested review of D110664: [Symbolize] Demangle Rust symbols.
Sep 28 2021, 3:30 PM · Restricted Project

Jul 1 2021

tmiasko added reviewers for D104366: [Demangle][Rust] Parse non-ASCII identifiers: erik.pilkington, ldionne.

Thanks for looking David!

Jul 1 2021, 1:23 AM · Restricted Project, Restricted Project
tmiasko updated the diff for D104366: [Demangle][Rust] Parse non-ASCII identifiers.
  • Rebase and resolve conflicts with D104362.
  • Return early on zero length insert.
Jul 1 2021, 12:16 AM · Restricted Project, Restricted Project

Jun 23 2021

tmiasko abandoned D99981: [demangler] Support the new Rust mangling scheme (v0).

For the record, support for Rust mangling scheme landed in:

Jun 23 2021, 3:07 PM · Restricted Project
tmiasko committed rG6cc6ada14323: [Demangle][Rust] Hide implementation details NFC (authored by tmiasko).
[Demangle][Rust] Hide implementation details NFC
Jun 23 2021, 9:30 AM
tmiasko closed D104362: [Demangle][Rust] Hide implementation details NFC.
Jun 23 2021, 9:30 AM · Restricted Project

Jun 18 2021

tmiasko updated the diff for D104366: [Demangle][Rust] Parse non-ASCII identifiers.
  • Avoid else after return.
Jun 18 2021, 12:44 AM · Restricted Project, Restricted Project
tmiasko committed rG2a5bb9c877f2: [Demangle][Rust] Parse dot suffix (authored by tmiasko).
[Demangle][Rust] Parse dot suffix
Jun 18 2021, 12:31 AM
tmiasko closed D104358: [Demangle][Rust] Parse dot suffix.
Jun 18 2021, 12:31 AM · Restricted Project

Jun 17 2021

tmiasko added inline comments to D104358: [Demangle][Rust] Parse dot suffix.
Jun 17 2021, 11:33 AM · Restricted Project
tmiasko updated the diff for D104358: [Demangle][Rust] Parse dot suffix.
  • Strip dot suffix before parsing
  • Include the dot in demangled output
Jun 17 2021, 11:30 AM · Restricted Project
tmiasko committed rG9b1085604ecf: [Demangle] Support Rust v0 mangling scheme in llvm::demangle (authored by tmiasko).
[Demangle] Support Rust v0 mangling scheme in llvm::demangle
Jun 17 2021, 1:40 AM
tmiasko closed D104340: [Demangle] Support Rust v0 mangling scheme in llvm::demangle.
Jun 17 2021, 1:40 AM · Restricted Project

Jun 16 2021

tmiasko requested review of D104366: [Demangle][Rust] Parse non-ASCII identifiers.
Jun 16 2021, 3:28 AM · Restricted Project, Restricted Project
tmiasko requested review of D104362: [Demangle][Rust] Hide implementation details NFC.
Jun 16 2021, 1:22 AM · Restricted Project
tmiasko requested review of D104358: [Demangle][Rust] Parse dot suffix.
Jun 16 2021, 12:07 AM · Restricted Project

Jun 15 2021

tmiasko requested review of D104340: [Demangle] Support Rust v0 mangling scheme in llvm::demangle.
Jun 15 2021, 4:38 PM · Restricted Project

Jun 8 2021

tmiasko committed rGf9a79356f223: [Demangle][Rust] Parse const backreferences (authored by tmiasko).
[Demangle][Rust] Parse const backreferences
Jun 8 2021, 1:03 AM
tmiasko committed rG44d63c57c129: [Demangle][Rust] Parse type backreferences (authored by tmiasko).
[Demangle][Rust] Parse type backreferences
Jun 8 2021, 1:03 AM
tmiasko committed rG82b7e822d005: [Demangle][Rust] Parse path backreferences (authored by tmiasko).
[Demangle][Rust] Parse path backreferences
Jun 8 2021, 1:03 AM
tmiasko closed D103848: [Demangle][Rust] Parse const backreferences.
Jun 8 2021, 1:03 AM · Restricted Project
tmiasko closed D103847: [Demangle][Rust] Parse type backreferences.
Jun 8 2021, 1:03 AM · Restricted Project
tmiasko closed D103459: [Demangle][Rust] Parse path backreferences.
Jun 8 2021, 1:03 AM · Restricted Project

Jun 7 2021

tmiasko added inline comments to D103459: [Demangle][Rust] Parse path backreferences.
Jun 7 2021, 3:05 PM · Restricted Project
tmiasko requested review of D103848: [Demangle][Rust] Parse const backreferences.
Jun 7 2021, 3:03 PM · Restricted Project
tmiasko requested review of D103847: [Demangle][Rust] Parse type backreferences.
Jun 7 2021, 3:02 PM · Restricted Project
tmiasko updated the diff for D103459: [Demangle][Rust] Parse path backreferences.

Parse path backreferences

Jun 7 2021, 3:00 PM · Restricted Project
tmiasko committed rG43929ccc1296: [Demangle][Rust] Parse instantiating crate (authored by tmiasko).
[Demangle][Rust] Parse instantiating crate
Jun 7 2021, 10:17 AM
tmiasko closed D103460: [Demangle][Rust] Parse instantiating crate.
Jun 7 2021, 10:17 AM · Restricted Project
tmiasko committed rG619a65e5e4ed: [Demangle][Rust] Parse dyn-trait-assoc-binding (authored by tmiasko).
[Demangle][Rust] Parse dyn-trait-assoc-binding
Jun 7 2021, 9:26 AM
tmiasko committed rG1499afa09ba2: [Demangle][Rust] Parse dyn-trait (authored by tmiasko).
[Demangle][Rust] Parse dyn-trait
Jun 7 2021, 9:25 AM
tmiasko committed rG89615a5e925e: [Demangle][Rust] Parse dyn-bounds (authored by tmiasko).
[Demangle][Rust] Parse dyn-bounds
Jun 7 2021, 9:25 AM
tmiasko closed D103364: [Demangle][Rust] Parse dyn-trait-assoc-binding.
Jun 7 2021, 9:25 AM · Restricted Project
tmiasko closed D103361: [Demangle][Rust] Parse dyn-trait.
Jun 7 2021, 9:25 AM · Restricted Project
tmiasko closed D103151: [Demangle][Rust] Parse dyn-bounds.
Jun 7 2021, 9:25 AM · Restricted Project

Jun 2 2021

tmiasko committed rGa67a234ec7aa: [Demangle][Rust] Parse binders (authored by tmiasko).
[Demangle][Rust] Parse binders
Jun 2 2021, 1:37 AM
tmiasko closed D102729: [Demangle][Rust] Parse binders.
Jun 2 2021, 1:37 AM · Restricted Project
tmiasko updated the diff for D103364: [Demangle][Rust] Parse dyn-trait-assoc-binding.
  • Remove IsOpen variable.
  • Use an enum for LeaveOpen.
Jun 2 2021, 1:21 AM · Restricted Project
tmiasko updated the diff for D103361: [Demangle][Rust] Parse dyn-trait.

Rebase

Jun 2 2021, 1:15 AM · Restricted Project
tmiasko added inline comments to D103151: [Demangle][Rust] Parse dyn-bounds.
Jun 2 2021, 1:05 AM · Restricted Project
tmiasko updated the diff for D103151: [Demangle][Rust] Parse dyn-bounds.

Rebase

Jun 2 2021, 1:04 AM · Restricted Project
tmiasko updated the diff for D102729: [Demangle][Rust] Parse binders.

Rerun build

Jun 2 2021, 12:46 AM · Restricted Project
tmiasko updated the diff for D102729: [Demangle][Rust] Parse binders.

Rename demangleBinder into demangleOptionalBinder

Jun 2 2021, 12:42 AM · Restricted Project

Jun 1 2021

tmiasko requested review of D103460: [Demangle][Rust] Parse instantiating crate.
Jun 1 2021, 6:59 AM · Restricted Project
tmiasko requested review of D103459: [Demangle][Rust] Parse path backreferences.
Jun 1 2021, 6:57 AM · Restricted Project

May 29 2021

tmiasko requested review of D103364: [Demangle][Rust] Parse dyn-trait-assoc-binding.
May 29 2021, 10:30 AM · Restricted Project
tmiasko requested review of D103361: [Demangle][Rust] Parse dyn-trait.
May 29 2021, 9:53 AM · Restricted Project

May 27 2021

tmiasko updated the diff for D103151: [Demangle][Rust] Parse dyn-bounds.

Parse dyn-bounds without any dyn-traits

May 27 2021, 11:42 AM · Restricted Project

May 26 2021

tmiasko requested review of D103151: [Demangle][Rust] Parse dyn-bounds.
May 26 2021, 3:49 AM · Restricted Project
tmiasko added inline comments to D102729: [Demangle][Rust] Parse binders.
May 26 2021, 3:36 AM · Restricted Project
tmiasko updated the diff for D102729: [Demangle][Rust] Parse binders.

Extend comment about +1 behaviour when parsing optional base-62 numbers.

May 26 2021, 3:36 AM · Restricted Project

May 22 2021

tmiasko updated the diff for D102729: [Demangle][Rust] Parse binders.

Rebuild after a change to a parent revision

May 22 2021, 5:22 AM · Restricted Project
tmiasko added inline comments to D102729: [Demangle][Rust] Parse binders.
May 22 2021, 5:10 AM · Restricted Project
tmiasko updated the diff for D102729: [Demangle][Rust] Parse binders.
  • Reuse the implementation for R and Q productions.
  • Reword the comment regarding invalid binders.
May 22 2021, 5:03 AM · Restricted Project
tmiasko closed D102580: [Demangle][Rust] Parse pointer types.
May 22 2021, 2:53 AM · Restricted Project
tmiasko committed rG75cc1cf0181a: [Demangle][Rust] Parse function signatures (authored by tmiasko).
[Demangle][Rust] Parse function signatures
May 22 2021, 2:52 AM
tmiasko committed rGe4fa6c95aca1: [Demangle][Rust] Parse references (authored by tmiasko).
[Demangle][Rust] Parse references
May 22 2021, 2:51 AM
tmiasko committed rG6aac56336d49: [Demangle][Rust] Parse raw pointers (authored by tmiasko).
[Demangle][Rust] Parse raw pointers
May 22 2021, 2:51 AM
tmiasko closed D102581: [Demangle][Rust] Parse function signatures.
May 22 2021, 2:51 AM · Restricted Project

May 19 2021

tmiasko added inline comments to D102579: [Demangle][Rust] Parse tuples.
May 19 2021, 11:58 AM · Restricted Project

May 18 2021

tmiasko committed rG57f408861d42: [Demangle][Rust] Speculative fix for bot build failure (authored by tmiasko).
[Demangle][Rust] Speculative fix for bot build failure
May 18 2021, 3:41 PM
tmiasko requested review of D102729: [Demangle][Rust] Parse binders.
May 18 2021, 3:19 PM · Restricted Project
tmiasko committed rG774de7a09bee: [Demangle][Rust] Parse tuples (authored by tmiasko).
[Demangle][Rust] Parse tuples
May 18 2021, 3:13 PM
tmiasko committed rGa84c65c204cc: [Demangle][Rust] Parse slice type (authored by tmiasko).
[Demangle][Rust] Parse slice type
May 18 2021, 3:13 PM
tmiasko committed rGb42400ccf3be: [Demangle][Rust] Parse array type (authored by tmiasko).
[Demangle][Rust] Parse array type
May 18 2021, 3:12 PM
tmiasko committed rG068332978c67: [Demangle][Rust] Parse named types (authored by tmiasko).
[Demangle][Rust] Parse named types
May 18 2021, 3:12 PM
tmiasko closed D102579: [Demangle][Rust] Parse tuples.
May 18 2021, 3:12 PM · Restricted Project
tmiasko closed D102578: [Demangle][Rust] Parse slice type.
May 18 2021, 3:12 PM · Restricted Project
tmiasko closed D102573: [Demangle][Rust] Parse array type.
May 18 2021, 3:12 PM · Restricted Project
tmiasko closed D102571: [Demangle][Rust] Parse named types.
May 18 2021, 3:12 PM · Restricted Project

May 17 2021

tmiasko updated the diff for D102581: [Demangle][Rust] Parse function signatures.

Replace and print ABI string character by character.

May 17 2021, 8:21 AM · Restricted Project