[Demangle][Rust] Parse function signatures

[tmiasko]

Summary

Depends on D102580

[dblaikie]

llvm/lib/Demangle/RustDemangle.cpp

500–507

Rather than using print and going back to modify the data - I think it might be nicer if this re-implemented print instead (it's simple enough - the error check and !Print check, seem OK). It does mean one more place printing things - but this loop/manipulation of the buffer is akin to "printing" something, and in a more surprising way.

[tmiasko]

Replace and print ABI string character by character.

[dblaikie]

Looks good, thanks!

llvm/include/llvm/Demangle/RustDemangle.h

public:
 
   bool demangle(StringView MangledName);
 
 private:
   void demanglePath(InType InType);
   void demangleImplPath(InType InType);
   void demangleGenericArg();
   void demangleType();
+  void demangleFnSig();
   void demangleConst();
   void demangleConstInt();
   void demangleConstBool();
   void demangleConstChar();
 
   Identifier parseIdentifier();
   uint64_t parseOptionalBase62Number(char Tag);
   uint64_t parseBase62Number();

llvm/lib/Demangle/RustDemangle.cpp

void Demangler::demangleType() {
   case 'P':
     print("*const ");
     demangleType();
     break;
   case 'O':
     print("*mut ");
     demangleType();
     break;
+  case 'F':
+    demangleFnSig();
+    break;
   default:
     Position = Start;
     demanglePath(rust_demangle::InType::Yes);
     break;
   }
 }
 
+// <fn-sig> := [<binder>] ["U"] ["K" <abi>] {<type>} "E" <type>
+// <abi> = "C"
+//       | <undisambiguated-identifier>
+void Demangler::demangleFnSig() {
+  // FIXME demangle binder.
+
+  if (consumeIf('U'))
+    print("unsafe ");
+
+  if (consumeIf('K')) {
+    print("extern \"");
+    if (consumeIf('C')) {
+      print("C");
+    } else {
+      Identifier Ident = parseIdentifier();
+      for (char C : Ident.Name) {
+        // When mangling ABI string, the "-" is replaced with "_".
+        if (C == '_')
+          C = '-';
+        print(C);
+      }
+    }
+    print("\" ");
+  }
+
+  print("fn(");
+  for (size_t I = 0; !Error && !consumeIf('E'); ++I) {
+    if (I > 0)
+      print(", ");
+    demangleType();
+  }
+  print(")");
+
+  if (consumeIf('u')) {
+    // Skip the unit type from the output.
+  } else {
+    print(" -> ");
+    demangleType();
+  }
+}
+
 // <const> = <basic-type> <const-data>
 //         | "p"                          // placeholder
 //         | <backref>
 void Demangler::demangleConst() {
   BasicType Type;
   if (parseBasicType(consume(), Type)) {
     switch (Type) {
     case BasicType::I8:

llvm/test/Demangle/rust.test

CHECK: types::<&mut _>
        _RIC5typesQpE
 
 CHECK: types::<*const _>
        _RIC5typesPpE
 
 CHECK: types::<*mut _>
        _RIC5typesOpE
 
+; Function signatures
+
+CHECK: function::<fn()>
+       _RIC8functionFEuE
+
+CHECK: function::<fn() -> _>
+       _RIC8functionFEpE
+
+CHECK: function::<fn(_)>
+       _RIC8functionFpEuE
+
+CHECK: function::<fn(_, _)>
+       _RIC8functionFppEuE
+
+CHECK: function::<fn(_, _, _)>
+       _RIC8functionFpppEuE
+
+CHECK: function::<unsafe fn()>
+       _RIC8functionFUEuE
+
+CHECK: function::<extern "C" fn()>
+       _RIC8functionFKCEuE
+
+CHECK: function::<extern "cdecl" fn()>
+       _RIC8functionFK5cdeclEuE
+
+CHECK: function::<unsafe extern "C-cmse-nonsecure-call" fn()>
+       _RIC8functionFUK21C_cmse_nonsecure_callEuE
+
 ; Integer constants. Test value demangling.
 
 CHECK: integer::<0>
        _RIC7integerKi0_E
 
 CHECK: integer::<1>
        _RIC7integerKi1_E