This is an archive of the discontinued LLVM Phabricator instance.

llvm/test/Demangle/rust.test
178–179	The changes in which features are used to test (for instance in the previous patch/tests - for "T" in this similar context, generic args ("p"/"_") were used, but this one uses u8 - it'd be good to be consistent unless there's a particular reason for the variation (in which case maybe a comment explaining what's significant, or not, about these cases, would be useful). (similarly back to the 'A' and 'S' productions in the types set, further up)

Use a placeholder type in tests.

Looks good, thanks!

Probably good to commit these as separate changes, since they seem independent.

This revision is now accepted and ready to land.May 21 2021, 5:05 PM

Revision Contents

Path

Size

llvm/

lib/

Demangle/

18 lines

test/

Demangle/

12 lines

Show First 20 Lines • Show All 448 Lines • ▼ Show 20 Lines	for (; !Error && !consumeIf('E'); ++I) {
print(", ");		print(", ");
demangleType();		demangleType();
}		}
if (I == 1)		if (I == 1)
print(",");		print(",");
print(")");		print(")");
break;		break;
}		}
		case 'R':
		print("&");
		// FIXME demangle [<lifetime>].
		demangleType();
		break;
		case 'Q':
		print("&mut ");
		// FIXME demangle [<lifetime>].
		demangleType();
		break;
		case 'P':
		print("*const ");
		demangleType();
		break;
		case 'O':
		print("*mut ");
		demangleType();
		break;
default:		default:
Position = Start;		Position = Start;
demanglePath(InType::Yes);		demanglePath(InType::Yes);
break;		break;
}		}
}		}

// <const> = <basic-type> <const-data>		// <const> = <basic-type> <const-data>
▲ Show 20 Lines • Show All 264 Lines • Show Last 20 Lines

Show First 20 Lines • Show All 169 Lines • ▼ Show 20 Lines	CHECK: types::<(_,)>
_RIC5typesTpEE		_RIC5typesTpEE

CHECK: types::<(_, _)>		CHECK: types::<(_, _)>
_RIC5typesTppEE		_RIC5typesTppEE

CHECK: types::<(_, _, _)>		CHECK: types::<(_, _, _)>
_RIC5typesTpppEE		_RIC5typesTpppEE

		CHECK: types::<&_>
		_RIC5typesRpE
		dblaikieUnsubmitted Done Reply Inline Actions The changes in which features are used to test (for instance in the previous patch/tests - for "T" in this similar context, generic args ("p"/"_") were used, but this one uses u8 - it'd be good to be consistent unless there's a particular reason for the variation (in which case maybe a comment explaining what's significant, or not, about these cases, would be useful). (similarly back to the 'A' and 'S' productions in the types set, further up) dblaikie: The changes in which features are used to test (for instance in the previous patch/tests - for…

		CHECK: types::<&mut _>
		_RIC5typesQpE

		CHECK: types::<*const _>
		_RIC5typesPpE

		CHECK: types::<*mut _>
		_RIC5typesOpE

; Integer constants. Test value demangling.		; Integer constants. Test value demangling.

CHECK: integer::<0>		CHECK: integer::<0>
_RIC7integerKi0_E		_RIC7integerKi0_E

CHECK: integer::<1>		CHECK: integer::<1>
_RIC7integerKi1_E		_RIC7integerKi1_E

▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines