This is an archive of the discontinued LLVM Phabricator instance.

[Demangle][Rust] Parse array type
ClosedPublic

Authored by tmiasko on May 16 2021, 2:44 AM.

Diff Detail

Event Timeline

tmiasko created this revision.May 16 2021, 2:44 AM
tmiasko requested review of this revision.May 16 2021, 2:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2021, 2:44 AM
dblaikie accepted this revision.May 16 2021, 10:21 AM
dblaikie added inline comments.
llvm/test/Demangle/rust.test
160–165

Is it worth having two tests here? The parser seems fairly orthogonally designed and generic args ('p') don't seem more likely to be buggy/weird than any other argument type, such as the u8/0 in the second case? Might be inclined towards only having the second test, unless there's some interesting interaction with the generic args I'm missing.

This revision is now accepted and ready to land.May 16 2021, 10:21 AM
tmiasko updated this revision to Diff 345882.May 17 2021, 7:53 AM
  • Remove redundant test case.
tmiasko marked an inline comment as done.May 17 2021, 7:54 AM
tmiasko added inline comments.
llvm/test/Demangle/rust.test
160–165

I left only the second test case (I wanted to test that code is parsing a <type> and a <const>, which is unclear with placeholders accepted by both).

This revision was landed with ongoing or failed builds.May 18 2021, 3:12 PM
This revision was automatically updated to reflect the committed changes.
tmiasko marked an inline comment as done.