Page MenuHomePhabricator

[OpenMP] Prevent Attributor from deleting functions in OpenMPOptCGSCC pass
ClosedPublic

Authored by jhuber6 on May 12 2021, 1:21 PM.

Details

Summary

This patch prevents the Attributor instances made in the CGSCC pass from
deleting functions. This prevents the attributor from changing the call
graph while OpenMPOpt is working with it.

Diff Detail

Event Timeline

jhuber6 created this revision.May 12 2021, 1:21 PM
jhuber6 requested review of this revision.May 12 2021, 1:21 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
This revision is now accepted and ready to land.May 12 2021, 1:23 PM

Test missing?
Shouldn't the deletions be simply deferred until after?

Test missing?
Shouldn't the deletions be simply deferred until after?

I don't think we need any tests, this is just a preemptive measure to avoid some future bugs.