Page MenuHomePhabricator

[MC][X86] Add TrapFillValue definition
Needs RevisionPublic

Authored by Amir on May 11 2021, 4:42 PM.

Details

Summary

Adds the parametrized TrapFillValue that is used to fill the executable
space with instructions that trap. Used by BOLT to overwrite functions.

Diff Detail

Event Timeline

Amir created this revision.May 11 2021, 4:42 PM
Amir published this revision for review.May 11 2021, 5:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2021, 5:38 PM
MaskRay requested changes to this revision.Jun 16 2021, 1:36 PM

Sorry for being late on reviews.

But it is not clear TrapFillValue needs to be built-in in MC. I worry such magic treatment of text sections vs non-text sections.
You can use the .fill directive in assembly

This revision now requires changes to proceed.Jun 16 2021, 1:36 PM