[MLIR][LinAlg] Fix a small compilation error.

[ergawy]

I might have misunderstood something. Let me know if I should abandon this in case this a local issue on my machine or there is a better solution.

[gysit]

Thanks for the fix!

I believe the builder takes an int64_t:

void ConstantIndexOp::build(OpBuilder &builder, OperationState &result,
                            int64_t value) {

Would casting to int64_t work as well? And out of curiosity for which compiler do you see the issue?

[ergawy]

I use: Apple clang version 11.0.3.

What made me think it is a local issue (after submitting the patch), is that there are 2 builders generated in LinalgOps.h.inc (for IndexOp which is used in this line not ConstantIndexOp):

static void build(::mlir::OpBuilder &odsBuilder, ::mlir::OperationState &odsState, int64_t dim);
static void build(::mlir::OpBuilder &odsBuilder, ::mlir::OperationState &odsState, uint64_t dim);

Maybe it's a case of needing a clean build on my end? Or is this on purpose?

[gysit]

well I added an additional builder that takes an int64_t dimension argument. I guess the proper solution is to remove one of the builders. I am still a bit confused you get a compilation error. Usually the compiler should chose the overload that is closest?

The clean solution is probably to remove one of the two builders. I think you code is also fine and I am fine with pushing it if it helps. Note that the pattern is temporary code anyways. Maybe try a rebuild and push if this doesn't help. I will investigate if I can remove the builder in meantime.

[ergawy]

Abandoned in favor of: D102055.

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

struct ConvertIndexedToGenericOp : OpRewritePattern<IndexedGenericOp> {
   LogicalResult matchAndRewrite(IndexedGenericOp indexedOp,
                                 PatternRewriter &rewriter) const override {
     // Replace all uses of the index block arguments.
     BlockAndValueMapping bvm;
     if (Block *body = indexedOp.getBody()) {
       rewriter.setInsertionPointToStart(body);
       for (const auto &en : llvm::enumerate(
                body->getArguments().take_front(indexedOp.getNumLoops()))) {
-        Value index = rewriter.create<IndexOp>(indexedOp.getLoc(), en.index());
+        Value index = rewriter.create<IndexOp>(
+            indexedOp.getLoc(), static_cast<uint64_t>(en.index()));
         bvm.map(en.value(), index);
       }
     }
 
     // Create a generic replacement operation and clone the body.
     rewriter.setInsertionPointAfter(indexedOp);
     SmallVector<StringRef> iterators = llvm::to_vector<4>(
         indexedOp.iterator_types().getAsValueRange<StringAttr>());