Page MenuHomePhabricator

[mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment.
ClosedPublic

Authored by sjarus on May 5 2021, 4:20 PM.

Details

Summary

Nearly complete alignment to spec v0.22

  • Adds Div op
  • Concat inputs now variadic
  • Removes Placeholder op

Note: TF side PR https://github.com/tensorflow/tensorflow/pull/48921 deletes Concat legalizations to avoid breaking TensorFlow CI. This must be merged only after the TF PR has merged.

Diff Detail

Event Timeline

sjarus created this revision.May 5 2021, 4:20 PM
sjarus requested review of this revision.May 5 2021, 4:20 PM

The implementation looks good however the description needs work. Be more specific than a TOSA version and preface with [mlir][tosa]. It helps contributors to note if this is a CL they should be interested with. Description should be along the lines of "Added tosa.div op and remove tosa.placeholder". For the LLVM repo the summary should focus on what is specifically changing.

sjarus retitled this revision from TOSA v0.22 updates part 2 to [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment..May 6 2021, 8:51 AM

The implementation looks good however the description needs work. Be more specific than a TOSA version and preface with [mlir][tosa]. It helps contributors to note if this is a CL they should be interested with. Description should be along the lines of "Added tosa.div op and remove tosa.placeholder". For the LLVM repo the summary should focus on what is specifically changing.

Seems I can use 'edit revision' to do this - and it shows as updated. I assume that takes care of this request ?

The implementation looks good however the description needs work. Be more specific than a TOSA version and preface with [mlir][tosa]. It helps contributors to note if this is a CL they should be interested with. Description should be along the lines of "Added tosa.div op and remove tosa.placeholder". For the LLVM repo the summary should focus on what is specifically changing.

Seems I can use 'edit revision' to do this - and it shows as updated. I assume that takes care of this request ?

Yup, that should be fine. When I patch and sync it should use the updated commit messages.

rsuderman accepted this revision.May 6 2021, 3:55 PM
This revision is now accepted and ready to land.May 6 2021, 3:55 PM