This is an archive of the discontinued LLVM Phabricator instance.

[mlir][vector] add pattern to cast away lead unit dimension for broadcast op
ClosedPublic

Authored by ThomasRaoux on May 5 2021, 4:04 PM.

Diff Detail

Event Timeline

ThomasRaoux created this revision.May 5 2021, 4:04 PM
ThomasRaoux requested review of this revision.May 5 2021, 4:04 PM
mravishankar requested changes to this revision.May 5 2021, 4:20 PM
mravishankar added inline comments.
mlir/test/Dialect/Vector/vector-transforms.mlir
679

Shouldnt this be just dropped? It seems like a no-op.

This revision now requires changes to proceed.May 5 2021, 4:20 PM
ThomasRaoux added inline comments.May 5 2021, 4:22 PM
mlir/test/Dialect/Vector/vector-transforms.mlir
679

Best would be to add a separate folding. Look like it isn't there right now. It would be better than adding it to this pattern. What do you think?

ThomasRaoux requested review of this revision.May 5 2021, 9:44 PM
mravishankar accepted this revision.May 5 2021, 11:12 PM
This revision is now accepted and ready to land.May 5 2021, 11:12 PM
This revision was landed with ongoing or failed builds.May 6 2021, 8:02 AM
This revision was automatically updated to reflect the committed changes.