This is an archive of the discontinued LLVM Phabricator instance.

Differential D101795

[mlir] Linalg: add vector transfer lowering patterns to the contraction lowering
ClosedPublic

Authored by ezhulenev on May 3 2021, 4:06 PM.

Details

Reviewers
nicolasvasilache
asaadaldien
Commits
rG9b67096fe952: [mlir] Linalg: add vector transfer lowering patterns to the contraction lowering
Summary

This fixes a performance regression in vec-mat vectorization

Diff Detail

Event Timeline

ezhulenev created this revision.May 3 2021, 4:06 PM
Herald added subscribers: dcaballe, cota, mravishankar and 17 others. · View Herald TranscriptMay 3 2021, 4:06 PM
ezhulenev requested review of this revision.May 3 2021, 4:06 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMay 3 2021, 4:06 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ezhulenev edited the summary of this revision. (Show Details)May 3 2021, 4:07 PM
ezhulenev added a reviewer: asaadaldien.
asaadaldien accepted this revision.May 3 2021, 4:09 PM
This revision is now accepted and ready to land.May 3 2021, 4:09 PM
This revision was landed with ongoing or failed builds.May 3 2021, 4:22 PM
Closed by commit rG9b67096fe952: [mlir] Linalg: add vector transfer lowering patterns to the contraction lowering (authored by ezhulenev). · Explain Why
This revision was automatically updated to reflect the committed changes.
ezhulenev added a commit: rG9b67096fe952: [mlir] Linalg: add vector transfer lowering patterns to the contraction lowering.
Harbormaster completed remote builds in B102411: Diff 342579.May 3 2021, 5:50 PM

Revision Contents

PathSize
mlir/
lib/
Dialect/
Linalg/
Transforms/
2 lines

Diff 342582

mlir/lib/Dialect/Linalg/Transforms/CodegenStrategy.cpp

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Linesvoid mlir::linalg::CodegenStrategy::transform(FuncOp func) const {
// Programmatic controlled lowering of vector.contract only. // Programmatic controlled lowering of vector.contract only.
if (lateCodegenStrategyOptions.enableVectorContractLowering) { if (lateCodegenStrategyOptions.enableVectorContractLowering) {
RewritePatternSet vectorContractLoweringPatterns(context); RewritePatternSet vectorContractLoweringPatterns(context);
vectorContractLoweringPatterns vectorContractLoweringPatterns
.add<ContractionOpToOuterProductOpLowering, .add<ContractionOpToOuterProductOpLowering,
ContractionOpToMatmulOpLowering, ContractionOpLowering>( ContractionOpToMatmulOpLowering, ContractionOpLowering>(
vectorTransformsOptions, context); vectorTransformsOptions, context);
vector::populateVectorTransferLoweringPatterns(
vectorContractLoweringPatterns);
(void)applyPatternsAndFoldGreedily( (void)applyPatternsAndFoldGreedily(
func, std::move(vectorContractLoweringPatterns)); func, std::move(vectorContractLoweringPatterns));
} }
// Programmatic controlled lowering of vector.transfer only. // Programmatic controlled lowering of vector.transfer only.
if (lateCodegenStrategyOptions.enableVectorToSCFConversion) { if (lateCodegenStrategyOptions.enableVectorToSCFConversion) {
RewritePatternSet vectorToLoopsPatterns(context); RewritePatternSet vectorToLoopsPatterns(context);
populateVectorToSCFConversionPatterns(vectorToLoopsPatterns, populateVectorToSCFConversionPatterns(vectorToLoopsPatterns,
Show All 9 Lines