Page MenuHomePhabricator

[mlir] Fix region successor bug in forward dataflow analysis
ClosedPublic

Authored by rriddle on Mon, May 3, 12:42 PM.

Details

Summary

We weren't properly visiting region successors when the terminator wasn't return like, which could create incorrect results in the analysis. This revision ensures that we properly visit region successors, to avoid optimistically assuming a value is constant when it isn't.

Diff Detail

Event Timeline

rriddle created this revision.Mon, May 3, 12:42 PM
rriddle requested review of this revision.Mon, May 3, 12:42 PM
mehdi_amini added inline comments.Mon, May 3, 1:57 PM
mlir/lib/Analysis/DataFlowAnalysis.cpp
570

This deserves a comment, I don't quite get it immediately

ftynse accepted this revision.Tue, May 4, 2:45 AM
This revision is now accepted and ready to land.Tue, May 4, 2:45 AM
rriddle updated this revision to Diff 342875.Tue, May 4, 2:50 PM
rriddle marked an inline comment as done.

update

This revision was landed with ongoing or failed builds.Tue, May 4, 2:59 PM
This revision was automatically updated to reflect the committed changes.