Page MenuHomePhabricator

[MLIR] Handle llvm.icmp of pointers
ClosedPublic

Authored by wsmoses on May 1 2021, 9:31 PM.

Diff Detail

Event Timeline

wsmoses created this revision.May 1 2021, 9:31 PM
wsmoses requested review of this revision.May 1 2021, 9:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2021, 9:31 PM
rriddle accepted this revision.May 1 2021, 9:33 PM

Thanks! Is anything needed for import/export?

mlir/test/Dialect/LLVMIR/roundtrip.mlir
28

Can you add a pointer vector test?

This revision is now accepted and ready to land.May 1 2021, 9:33 PM
wsmoses marked an inline comment as done.May 1 2021, 10:14 PM
wsmoses added inline comments.
mlir/test/Dialect/LLVMIR/roundtrip.mlir
28

An initial look at doing so demonstrates that vectors do not presently support LLVM.pointer as arguments, making such a test impossible at the moment. This should likely be remedied (being a ~index type) but in a future PR.

wsmoses marked an inline comment as done.May 1 2021, 10:17 PM
wsmoses added inline comments.
mlir/test/Dialect/LLVMIR/roundtrip.mlir
28

Oh whoops, used the wrong vector type in the test when I ran that. Done.

This revision was landed with ongoing or failed builds.May 1 2021, 10:18 PM
This revision was automatically updated to reflect the committed changes.