This is an archive of the discontinued LLVM Phabricator instance.

Differential D101664

[NewPM] Disable RelLookupTableConverter pass in lto
ClosedPublic

Authored by gulfem on Apr 30 2021, 2:00 PM.

Details

Reviewers
leonardchan
phosek
Commits
rG4423a7a09b1b: [NewPM] Disable RelLookupTableConverter pass in LTO
Summary

Relative look table converter pass caused an issue when full lto
is enabled (reported in https://reviews.llvm.org/D94355).
This patch disables that pass from full lto pre-link phase optimization
pipeline until the issue is fixed.

Diff Detail

Event Timeline

gulfem created this revision.Apr 30 2021, 2:00 PM
Herald added subscribers: hiraditya, inglorion. · View Herald TranscriptApr 30 2021, 2:00 PM
gulfem requested review of this revision.Apr 30 2021, 2:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2021, 2:00 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
gulfem added reviewers: leonardchan, phosek.Apr 30 2021, 2:03 PM
gulfem added a subscriber: nathanchance.
phosek accepted this revision.Apr 30 2021, 2:16 PM

LGTM

This revision is now accepted and ready to land.Apr 30 2021, 2:16 PM
This revision was landed with ongoing or failed builds.Apr 30 2021, 2:24 PM
Closed by commit rG4423a7a09b1b: [NewPM] Disable RelLookupTableConverter pass in LTO (authored by gulfem). · Explain Why
This revision was automatically updated to reflect the committed changes.
gulfem added a commit: rG4423a7a09b1b: [NewPM] Disable RelLookupTableConverter pass in LTO.
Harbormaster completed remote builds in B102012: Diff 342030.Apr 30 2021, 4:37 PM

Revision Contents

PathSize
llvm/
lib/
Passes/
6 lines
test/
Other/
6 lines

Diff 342040

llvm/lib/Passes/PassBuilder.cpp

Show First 20 Lines • Show All 1,419 Lines • ▼ Show 20 LinesPassBuilder::buildModuleOptimizationPipeline(OptimizationLevel Level,
// Now we need to do some global optimization transforms. // Now we need to do some global optimization transforms.
// FIXME: It would seem like these should come first in the optimization // FIXME: It would seem like these should come first in the optimization
// pipeline and maybe be the bottom of the canonicalization pipeline? Weird // pipeline and maybe be the bottom of the canonicalization pipeline? Weird
// ordering here. // ordering here.
MPM.addPass(GlobalDCEPass()); MPM.addPass(GlobalDCEPass());
MPM.addPass(ConstantMergePass()); MPM.addPass(ConstantMergePass());
// TODO: Relative look table converter pass caused an issue when full lto is
// enabled. See https://reviews.llvm.org/D94355 for more details.
// Until the issue fixed, disable this pass during pre-linking phase.
if (!LTOPreLink)
MPM.addPass(RelLookupTableConverterPass()); MPM.addPass(RelLookupTableConverterPass());
return MPM; return MPM;
} }
ModulePassManager ModulePassManager
PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level, PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level,
bool LTOPreLink) { bool LTOPreLink) {
assert(Level != OptimizationLevel::O0 && assert(Level != OptimizationLevel::O0 &&
▲ Show 20 Lines • Show All 1,756 Lines • Show Last 20 Lines

llvm/test/Other/new-pm-defaults.ll

Show First 20 Lines • Show All 254 Lines • ▼ Show 20 Lines
; CHECK-O-NEXT: Running pass: DivRemPairsPass ; CHECK-O-NEXT: Running pass: DivRemPairsPass
; CHECK-O-NEXT: Running pass: SimplifyCFGPass ; CHECK-O-NEXT: Running pass: SimplifyCFGPass
; CHECK-O-NEXT: Running pass: SpeculateAroundPHIsPass ; CHECK-O-NEXT: Running pass: SpeculateAroundPHIsPass
; CHECK-EP-OPTIMIZER-LAST: Running pass: NoOpFunctionPass ; CHECK-EP-OPTIMIZER-LAST: Running pass: NoOpFunctionPass
; CHECK-O-NEXT: Finished llvm::Function pass manager run. ; CHECK-O-NEXT: Finished llvm::Function pass manager run.
; CHECK-O-NEXT: Running pass: CGProfilePass ; CHECK-O-NEXT: Running pass: CGProfilePass
; CHECK-O-NEXT: Running pass: GlobalDCEPass ; CHECK-O-NEXT: Running pass: GlobalDCEPass
; CHECK-O-NEXT: Running pass: ConstantMergePass ; CHECK-O-NEXT: Running pass: ConstantMergePass
; CHECK-O-NEXT: Running pass: RelLookupTableConverterPass ; CHECK-DEFAULT-NEXT: Running pass: RelLookupTableConverterPass
; CHECK-O-NEXT: Running analysis: TargetIRAnalysis ; CHECK-LTO-NOT: Running pass: RelLookupTableConverterPass
; CHECK-DEFAULT-NEXT: Running analysis: TargetIRAnalysis
; CHECK-LTO-NOT: Running analysis: TargetIRAnalysis
; CHECK-O-NEXT: Running pass: AnnotationRemarksPass on foo ; CHECK-O-NEXT: Running pass: AnnotationRemarksPass on foo
; CHECK-LTO-NEXT: Running pass: CanonicalizeAliasesPass ; CHECK-LTO-NEXT: Running pass: CanonicalizeAliasesPass
; CHECK-LTO-NEXT: Running pass: NameAnonGlobalPass ; CHECK-LTO-NEXT: Running pass: NameAnonGlobalPass
; CHECK-O-NEXT: Running pass: PrintModulePass ; CHECK-O-NEXT: Running pass: PrintModulePass
; ;
; Make sure we get the IR back out without changes when we print the module. ; Make sure we get the IR back out without changes when we print the module.
; CHECK-O-LABEL: define void @foo(i32 %n) local_unnamed_addr { ; CHECK-O-LABEL: define void @foo(i32 %n) local_unnamed_addr {
; CHECK-O-NEXT: entry: ; CHECK-O-NEXT: entry:
Show All 27 Lines