Page MenuHomePhabricator

[AMDGPU][AsmParser] Adjust img instruction address field if a16 present
AbandonedPublic

Authored by dstuttard on Apr 30 2021, 5:29 AM.

Details

Reviewers
foad
rampitec
dp
Summary

A16 support for image instructions assembly (gfx10) was missing

Diff Detail

Event Timeline

dstuttard created this revision.Apr 30 2021, 5:29 AM
dstuttard requested review of this revision.Apr 30 2021, 5:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2021, 5:29 AM
dstuttard updated this revision to Diff 341860.Apr 30 2021, 5:40 AM

IsA16 now bool so should not be set to 1 : 0

foad added a reviewer: dp.Apr 30 2021, 12:50 PM
dstuttard updated this revision to Diff 344357.May 11 2021, 4:29 AM

a16 and g16 no longer linked

dp added a comment.May 11 2021, 5:17 AM

The patch looks identical to your previous one. Possibly an update quirk?

dstuttard abandoned this revision.May 11 2021, 5:17 AM

I've combined this with other changes into D102231 which was easier than trying to update this one